Make metric indexes unique #7237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groxx
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Groxx
commented
Sep 4, 2025
Comment on lines
+56
to
+59
| func (s scopeDefinition) GetOperationString() string { | ||
| return s.operation | ||
| } | ||
|
|
There was a problem hiding this comment.
could remove this - it's mostly just prep-work since almost anything leaving the scope-index ints will need it.
This was referenced Sep 4, 2025
| // cluster forwarding policy metrics | ||
| ClusterForwardingPolicyRequests | ||
|
|
||
| RingResolverError |
There was a problem hiding this comment.
what's the deal with this one? did it get missed somewhere?
davidporter-id-au
approved these changes
Sep 4, 2025
|
Yea, works for me at least. I didn't see anything in the process of doing #7238, so I think the worst case might be something in our internal code, and I don't think we have any unique metrics in there tbh. All re-used names (which probably would break prometheus, if we used it internally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part cleanup due to discoveries in e.g. #7210, part prep-work for migrating metrics to almost literally any new setup (to make that easier and safer, by allowing int -> name lookups).
I believe this is a safe thing to do, as we don't seem to do anything fancy with the metric-def indexes.
But it's quite hard to verify because we don't have a unique type (fixed in #7238) and all the code here is rather value-oriented and fallback-y so it's hard to be totally confident that everything is handled.