[shard-distributor] Fix: forgot to update a mapper #7242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
3vilhamster,
Groxx,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
c-warren
approved these changes
Sep 8, 2025
There was a problem hiding this comment.
Once my "fuzz" testing PR is in for our proto<>thrift mappers it would be worthwhile adding similar testing for the mappers in this file as well: cadence-workflow/cadence-go-client#1457
Alternatively, adding tests that test the various permutations of the mapper would be worthwhile to ensure we get the expected result based on the input should catch this sort of thing in the future (though were you to do that I'd recommend breaking out the Status convertors into their own function to minimize the permutations that need to be tested).
|
Thank you! Yeah I do think we could do a better test of this pretty easily - I'll make a task. A generic solution would be wonderful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added the Done state to the mapper
Why?
Forget it when I added the new status
How did you test it?
Potential risks
Release notes
Documentation Changes