Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions .github/workflows/ci-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run unit test
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run golint
run: docker compose -f docker/github_actions/docker-compose.yml run coverage-report bash -c "./scripts/github_actions/golint.sh"
Expand All @@ -86,7 +86,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run integration profile for cassandra
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run integration profile for cassandra running history queue v2
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run integration profile for cassandra running history queue v2 with alert
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run integration profile for cassandra and elasticsearch v7
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -211,7 +211,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run integration test with cassandra and pinot
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -243,7 +243,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run integration profile for cassandra and opensearch v2
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -275,7 +275,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run ndc profile for cassandra
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -307,7 +307,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run integration profile for mysql
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -339,7 +339,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run ndc profile for mysql
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -371,7 +371,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run integration profile for postgres
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -402,7 +402,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run integration profile for sqlite
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -433,7 +433,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run ndc profile for postgres
uses: nick-fields/retry@v3
Expand Down Expand Up @@ -464,7 +464,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run async wf integration test with kafka
uses: nick-fields/retry@v3
Expand All @@ -488,7 +488,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run integration test with etcd
uses: nick-fields/retry@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codecov-on-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: 1.23.4
go-version: 1.24.7
cache: false
- name: Download dependencies
run: go mod download
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codecov-on-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: 1.23.4
go-version: 1.24.7
cache: false

- name: Download dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/replication-simulation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Setup Go environment
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
go-version: '1.24.7'

- name: Run simulation
uses: nick-fields/retry@v3
Expand Down
85 changes: 85 additions & 0 deletions .mockery.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
all: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, is this intended to be comprehensive or it's just some problematic ones?

Copy link
Member Author

@Groxx Groxx Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"all" is for whether it'll generate mocks of every interface it discovers, or if it's an explicit list (below). e.g. you could use it for "all" in a subdir, if it always contained interfaces you wanted to mock (like an "interfaces" dir).

I don't think we'll ever get even close to wanting that tho :)

log-level: info
dir: "{{.InterfaceDirRelative}}"
structname: "Mock{{.InterfaceName}}"
# interfacefile is an absolute path, get basename and rewrite
filename: "{{.InterfaceFile | base | replaceAll \".go\" \"_mock.go\"}}"
pkgname: "{{.SrcPackageName}}"
packages:
github.com/aws/aws-sdk-go/service/s3/s3iface:
config:
dir: "common/archiver/s3store/mocks"
filename: "s3_api_mock.go"
structname: "{{.InterfaceName}}"
pkgname: "mocks"
interfaces:
S3API:
github.com/uber/cadence/common/archiver:
config:
filename: "interface_mock.go"
structname: "{{.InterfaceName}}Mock"
interfaces:
HistoryArchiver:
VisibilityArchiver:
github.com/uber/cadence/common/archiver/gcloud/connector:
config:
dir: "common/archiver/gcloud/connector/mocks"
pkgname: "mocks"
filename: "{{.InterfaceName}}.go"
structname: "{{.InterfaceName}}"
interfaces:
Client:
GcloudStorageClient:
BucketHandleWrapper:
ObjectHandleWrapper:
ObjectIteratorWrapper:
ReaderWrapper:
WriterWrapper:
github.com/uber/cadence/common/archiver/provider:
interfaces:
ArchiverProvider:
github.com/uber/cadence/common/blobstore:
interfaces:
Client:
github.com/uber/cadence/common/elasticsearch:
config:
dir: "common/elasticsearch/mocks"
pkgname: "mocks"
filename: "{{.InterfaceName}}.go"
structname: "{{.InterfaceName}}"
interfaces:
GenericClient:
github.com/uber/cadence/common/elasticsearch/bulk:
config:
dir: "common/elasticsearch/bulk/mocks"
pkgname: "mocks"
filename: "{{.InterfaceName}}.go"
structname: "{{.InterfaceName}}"
interfaces:
GenericBulkableRequest:
GenericBulkProcessor:
github.com/uber/cadence/common/metrics:
config:
dir: "common/metrics/mocks"
pkgname: "mocks"
filename: "{{.InterfaceName}}.go"
structname: "{{.InterfaceName}}"
interfaces:
Client:
Scope:
github.com/uber/cadence/common/persistence:
config:
dir: "common/mocks"
pkgname: "mocks"
filename: "{{.InterfaceName}}.go"
structname: "{{.InterfaceName}}"
interfaces:
ExecutionManager:
TaskManager:
VisibilityManager:
ShardManager:
github.com/uber/cadence/service/worker/parentclosepolicy:
config:
structname: "ClientMock"
interfaces:
Client:
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ARG TARGET=server
ARG GOPROXY

# Build Cadence binaries
FROM golang:1.23.4-alpine3.21 AS builder
FROM golang:1.24.7-alpine3.21 AS builder
Copy link
Member Author

@Groxx Groxx Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a bit to convert our github-action to alpine too, but hit too many barriers and gave up fairly quickly :|

probably doesn't matter if the actions/setup-go ones are debian/ubuntu? though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, as long as the images are cached, debian's honestly usually a little easier to work with


ARG RELEASE_VERSION

Expand Down
Loading
Loading