fix: refactoring some of the domain handler #7320
Open
+221
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Porter <[email protected]> - Changes the flags being passed around to be consistent with their use outside - s/clusterUpdated/replicationConfigChanged/g - s/activeClusterUpdated/activeClusterChanged/g - Documents their intended behaviour
Signed-off-by: David Porter <[email protected]>
davidporter-id-au
changed the title
Signed-off-by: David Porter <[email protected]>
davidporter-id-au
requested review from
3vilhamster,
Groxx,
Shaddoll,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: David Porter <[email protected]>
| activeClusterSelectionPolicy: | ||
| clusterAttribute: | ||
| scope: region | ||
| name: region0 |
There was a problem hiding this comment.
we need the clusters to be valid
There was a problem hiding this comment.
this is not the cluster name. It's the cluster attribute name
There was a problem hiding this comment.
you're right, I'm confused 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
epic: #6697
Reviewing this is probably a little hard, so I suggest looking at the three commits as they are distinct and (hopefully) fairly easy to follow refactors.
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes