fix: correct cluster attributes being set when both legacy and new are passed in #7330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d0ee3a1. Signed-off-by: David Porter <[email protected]>
Signed-off-by: David Porter <[email protected]>
| _, existsAlready := mergedActiveClusters.AttributeScopes[newScope] | ||
| if !existsAlready { | ||
| mergedActiveClusters.AttributeScopes[newScope] = newScopeData | ||
| isChanged = true |
There was a problem hiding this comment.
the actual fix
davidporter-id-au
changed the title
davidporter-id-au
requested review from
3vilhamster,
Groxx,
Shaddoll,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: David Porter <[email protected]>
davidporter-id-au
force-pushed
the
bugfix/fix-arr-update
branch
from
fdcdaf3 to
30bad01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
in some of the integration-tests, they were not failing over a domain's cluster-attributes correctly. This was due to a bug in the merging-cluster-attributes code which didn't correctly flag the attributes as having changed when they should have. The whole section needs both better validation and more test coverage. I've a few followup PRs for this.
As an aside, there actual input-data is quite weird, so I think there's both some test setup problems which I've not identified and possibly a strange/possibly wrong assumption in the previous attributesByRegion code. But since it's going away maybe that doesn't matter.
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes