feat(shard-distributor): return executor metadata from spectator GetShardOwner #7476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
jakobht
force-pushed
the
spectator-return-metadata
branch
from
fe40b7d to
d338c46
Compare
Previously GetShardOwner only returned the executor ID string. Now it returns an ExecutorOwnership struct containing both the executor ID and the full metadata map. This allows callers to access additional executor information like the gRPC address needed for peer routing. Changes: - Add ExecutorOwnership struct with ExecutorID and Metadata fields - Update GetShardOwner signature to return *ExecutorOwnership - Update spectatorImpl to build and return ownership info - Update tests to verify metadata is included in responses Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Use BlockUntil() to properly synchronize with the fake clock before advancing time. This prevents the test from hanging while waiting for the goroutine to process the time advancement. Signed-off-by: Jakob Haahr Taankvist <[email protected]>
jakobht
force-pushed
the
spectator-return-metadata
branch
from
fc14633 to
2e5ff6c
Compare
eleonoradgr
reviewed
Nov 26, 2025
eleonoradgr
approved these changes
Nov 26, 2025
Encapsulate the spectators map in a struct to hide implementation details and make it easier to extend in the future without breaking the API. Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Changed
GetShardOwnerto return anExecutorOwnershipstruct containing both executor ID and metadata map, instead of just the executor ID string.Also adds a Spectators group so we can easily pass around all spectators.
Why?
Enables callers to access additional executor information like gRPC address for peer routing, without requiring separate lookups. This is needed for implementing canary peer chooser that routes requests to executors based on their addresses.
How did you test it?
Updated all tests to verify metadata is included in responses. Verified locally that ownership information includes metadata.
Potential risks
Low - this is an API enhancement that maintains backward compatibility by returning the same executor ID, just with additional metadata.
Release notes
Documentation Changes
None