feat(shard-distributor): add canary ping handler for executor health checks #7486
+213
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Implement the server-side handler for canary ping requests. The handler receives ping requests for specific shards and responds with whether this executor owns the shard. The handler: 1. Looks up the executor for the requested namespace 2. Checks if this executor owns the requested shard 3. Returns ownership status and executor ID This allows other executors to verify shard ownership and test executor-to-executor communication. Dependencies: - Requires ShardDistributorExecutorCanaryAPI proto definition - Requires Executor.GetMetadata() to identify the executor Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Add table-driven tests covering: - Fixed executor shard ownership verification - Ephemeral executor shard ownership verification - Executor ID extraction from grpc_address metadata Achieves 93.3% test coverage. Signed-off-by: Jakob Haahr Taankvist <[email protected]>
jakobht
force-pushed
the
add-canary-ping-handler
branch
from
5a0cfed to
ba69285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7475 being merged
What changed?
Added server-side ping handler for canary health checks in the shard distributor. The handler responds to ping requests from other executors, verifying shard ownership.
Why?
Enables executor-to-executor health verification in the canary system. The ping handler allows executors to check if peer executors own specific shards and are functioning correctly.
How did you test it?
Unit tests
Potential risks
Release notes
Documentation Changes