Skip to content

chore: Assign an open-source lead to PRs from external users#7658

Merged
c-warren merged 5 commits intocadence-workflow:masterfrom
c-warren:cwarren/gitar_assigner
Feb 17, 2026
Merged

chore: Assign an open-source lead to PRs from external users#7658
c-warren merged 5 commits intocadence-workflow:masterfrom
c-warren:cwarren/gitar_assigner

Conversation

@c-warren
Copy link
Contributor

What changed?

Adds a Gitar rule to assign all pull requests from outside of Cadence's codeowners to an internal team member.

Why?

To improve our response time for PRs created by external users and reduce the overhead for external contributors to find someone to review their PR this rule will assign a user who is responsible for delegating review of the PR to a cadence team member.

How did you test it?

Testing it right now!

Potential risks

N/A

Release notes

N/A

Documentation Changes

N/A


Reviewer Validation

PR Description Quality (check these before reviewing code):

  • "What changed" provides a clear 1-2 line summary
    • Project Issue is linked
  • "Why" explains the full motivation with sufficient context
  • Testing is documented:
    • Unit test commands are included (with exact go test invocation)
    • Integration test setup/commands included (if integration tests were run)
    • Canary testing details included (if canary was mentioned)
  • Potential risks section is thoughtfully filled out (or legitimately N/A)
  • Release notes included if this completes a user-facing feature
  • Documentation needs are addressed (or noted if uncertain)

@c-warren
Copy link
Contributor Author

gitar display:verbose

@gitar-bot gitar-bot bot requested a review from demirkayaender January 29, 2026 21:47
@c-warren
Copy link
Contributor Author

gitar auto-apply:on

@c-warren c-warren merged commit b140a12 into cadence-workflow:master Feb 17, 2026
41 checks passed
@c-warren c-warren deleted the cwarren/gitar_assigner branch February 17, 2026 21:29
@gitar-bot
Copy link

gitar-bot bot commented Feb 17, 2026

Code Review ⚠️ Changes requested 0 resolved / 2 findings

New Gitar rule for auto-assigning reviewers to external PRs has a maintainer consistency issue: @zawadzkidiana is in the rotation pool but absent from CODEOWNERS, which the rule uses to distinguish internal vs. external contributors.

⚠️ Edge Case: @zawadzkidiana is in rotation pool but missing from CODEOWNERS

📄 .gitar/rules/assign-maintainer-reviewer.md:16

@zawadzkidiana is listed as a round-robin reviewer in the rotation pool (line 16), and is listed in MAINTAINERS.md as a maintainer, but is not present in .github/CODEOWNERS.

Since the rule determines "external contributor" status by checking .github/CODEOWNERS (line 21: "Do not assign a reviewer if the PR author is already a maintainer listed in CODEOWNERS"), PRs authored by @zawadzkidiana would be incorrectly classified as external. This could result in:

  1. @natemort being assigned to triage their PRs unnecessarily
  2. @zawadzkidiana potentially being assigned via round-robin to review their own PR

Either add @zawadzkidiana to .github/CODEOWNERS (to match their status in MAINTAINERS.md), or remove them from the rotation pool if they are not yet a full codeowner.

💡 Edge Case: Rule only triggers on "opened" — misses reopened PRs

📄 .gitar/rules/assign-maintainer-reviewer.md:4

The when trigger is set to Pull request is opened (line 4). This means the rule won't fire when a previously closed PR is reopened, or when a draft PR is marked ready for review. External contributors sometimes open PRs as drafts and later mark them ready, or close and reopen PRs after making changes.

Consider expanding the trigger to also cover reopened and/or ready_for_review events to avoid missing external PRs that follow these workflows. For example:

when: Pull request is opened, reopened, or marked ready for review
Rules

Repository Rules

Assign Maintainer Reviewer for External Contributors: PR author c-warren is a maintainer in CODEOWNERS; rule does not apply to maintainer-authored PRs
PR Description Quality Standards: Rule triggers on PR description updates; current event is not a description modification

Hide rules that don't apply by commenting gitar display:compact.

Options ✅ Auto-apply

✅ Auto-apply is on → Gitar will commit updates to this branch.
Display: verbose → Showing more information.

Comment with these commands to change:

✅ Auto-apply Verbose
gitar auto-apply:off         
gitar display:compact         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants