You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds a Gitar rule to assign all pull requests from outside of Cadence's codeowners to an internal team member.
Why?
To improve our response time for PRs created by external users and reduce the overhead for external contributors to find someone to review their PR this rule will assign a user who is responsible for delegating review of the PR to a cadence team member.
How did you test it?
Testing it right now!
Potential risks
N/A
Release notes
N/A
Documentation Changes
N/A
Reviewer Validation
PR Description Quality (check these before reviewing code):
"What changed" provides a clear 1-2 line summary
Project Issue is linked
"Why" explains the full motivation with sufficient context
Testing is documented:
Unit test commands are included (with exact go test invocation)
Integration test setup/commands included (if integration tests were run)
Canary testing details included (if canary was mentioned)
Potential risks section is thoughtfully filled out (or legitimately N/A)
Release notes included if this completes a user-facing feature
Documentation needs are addressed (or noted if uncertain)
New Gitar rule for auto-assigning reviewers to external PRs has a maintainer consistency issue: @zawadzkidiana is in the rotation pool but absent from CODEOWNERS, which the rule uses to distinguish internal vs. external contributors.
⚠️Edge Case:@zawadzkidiana is in rotation pool but missing from CODEOWNERS
@zawadzkidiana is listed as a round-robin reviewer in the rotation pool (line 16), and is listed in MAINTAINERS.md as a maintainer, but is not present in .github/CODEOWNERS.
Since the rule determines "external contributor" status by checking .github/CODEOWNERS (line 21: "Do not assign a reviewer if the PR author is already a maintainer listed in CODEOWNERS"), PRs authored by @zawadzkidiana would be incorrectly classified as external. This could result in:
@natemort being assigned to triage their PRs unnecessarily
@zawadzkidiana potentially being assigned via round-robin to review their own PR
Either add @zawadzkidiana to .github/CODEOWNERS (to match their status in MAINTAINERS.md), or remove them from the rotation pool if they are not yet a full codeowner.
💡 Edge Case: Rule only triggers on "opened" — misses reopened PRs
The when trigger is set to Pull request is opened (line 4). This means the rule won't fire when a previously closed PR is reopened, or when a draft PR is marked ready for review. External contributors sometimes open PRs as drafts and later mark them ready, or close and reopen PRs after making changes.
Consider expanding the trigger to also cover reopened and/or ready_for_review events to avoid missing external PRs that follow these workflows. For example:
when: Pull request is opened, reopened, or marked ready for review
Rules
Repository Rules
➖ Assign Maintainer Reviewer for External Contributors: PR author c-warren is a maintainer in CODEOWNERS; rule does not apply to maintainer-authored PRs
➖ PR Description Quality Standards: Rule triggers on PR description updates; current event is not a description modification
Hide rules that don't apply by commenting gitar display:compact.
Options✅ Auto-apply
✅ Auto-apply is on → Gitar will commit updates to this branch. Display: verbose → Showing more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Adds a Gitar rule to assign all pull requests from outside of Cadence's codeowners to an internal team member.
Why?
To improve our response time for PRs created by external users and reduce the overhead for external contributors to find someone to review their PR this rule will assign a user who is responsible for delegating review of the PR to a cadence team member.
How did you test it?
Testing it right now!
Potential risks
N/A
Release notes
N/A
Documentation Changes
N/A
Reviewer Validation
PR Description Quality (check these before reviewing code):
go testinvocation)