feat(domain multi-tenancy): Pull latest idl changes#7723
feat(domain multi-tenancy): Pull latest idl changes#7723Shaddoll merged 1 commit intocadence-workflow:masterfrom
Conversation
🔍 CI failure analysis for 807757d: TestWatchLoopDisabled unit test continues to fail with race condition - expected error but got nil. This flaky test is unrelated to PR changes and has now failed multiple times.Golang Unit Test - TestWatchLoopDisabled (Persistent Flaky Test)IssueTest fails in Root CauseThe test expects an error from Error: DetailsThis is unrelated to PR changes. The PR only modifies:
The failing test is in Persistent Flakiness: This test has now failed multiple times across different CI runs (timestamps 19:32:53 and 19:42:20 in the latest run), confirming it's a consistently flaky test. The test uses The test is testing timing/signal behavior with mock clocks, and the expected error is not occurring consistently due to race conditions in the test itself. Code Review ✅ ApprovedClean IDL update adding three new optional fields (AutoForwardingEnabled, TimerTaskInfo.TaskList, TransferTaskInfo.OriginalTaskList) with proper serialization, getters, and round-trip test coverage following established patterns. Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
What changed?
Pull latest idl changes and update internal types to include the task list fields introduced in the idl changes.
#7724
Why?
Update IDL
How did you test it?
unit test
cd common/persistence/serialization && go test ./...Potential risks
N/A
Release notes
Documentation Changes
N/A
Reviewer Validation
PR Description Quality (check these before reviewing code):
go testinvocation)