Skip to content

feat(domain multi-tenancy): Pull latest idl changes#7723

Merged
Shaddoll merged 1 commit intocadence-workflow:masterfrom
Shaddoll:idl
Feb 19, 2026
Merged

feat(domain multi-tenancy): Pull latest idl changes#7723
Shaddoll merged 1 commit intocadence-workflow:masterfrom
Shaddoll:idl

Conversation

@Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Feb 19, 2026

What changed?
Pull latest idl changes and update internal types to include the task list fields introduced in the idl changes.
#7724

Why?
Update IDL

How did you test it?
unit test
cd common/persistence/serialization && go test ./...

Potential risks
N/A

Release notes

Documentation Changes
N/A


Reviewer Validation

PR Description Quality (check these before reviewing code):

  • "What changed" provides a clear 1-2 line summary
    • Project Issue is linked
  • "Why" explains the full motivation with sufficient context
  • Testing is documented:
    • Unit test commands are included (with exact go test invocation)
    • Integration test setup/commands included (if integration tests were run)
    • Canary testing details included (if canary was mentioned)
  • Potential risks section is thoughtfully filled out (or legitimately N/A)
  • Release notes included if this completes a user-facing feature
  • Documentation needs are addressed (or noted if uncertain)

@gitar-bot
Copy link

gitar-bot bot commented Feb 19, 2026

🔍 CI failure analysis for 807757d: TestWatchLoopDisabled unit test continues to fail with race condition - expected error but got nil. This flaky test is unrelated to PR changes and has now failed multiple times.

Golang Unit Test - TestWatchLoopDisabled (Persistent Flaky Test)

Issue

Test fails in service/sharddistributor/client/spectatorclient/clientimpl_test.go:285

Root Cause

The test expects an error from stateSignal.Wait(context.Background()) but receives nil instead.

Error:

Error Trace: /cadence/service/sharddistributor/client/spectatorclient/clientimpl_test.go:285
Error:       An error is expected but got nil.
Test:        TestWatchLoopDisabled

Details

This is unrelated to PR changes. The PR only modifies:

  • IDL-generated code (.gen/go/)
  • Serialization layer (common/persistence/serialization/)
  • IDL submodule and go.mod references

The failing test is in service/sharddistributor/client/spectatorclient/, which is not touched by this PR.

Persistent Flakiness: This test has now failed multiple times across different CI runs (timestamps 19:32:53 and 19:42:20 in the latest run), confirming it's a consistently flaky test. The test uses sync.WaitGroup and mock time sources (timeSource.BlockUntil, timeSource.Advance), which are prone to race conditions in CI environments.

The test is testing timing/signal behavior with mock clocks, and the expected error is not occurring consistently due to race conditions in the test itself.

Code Review ✅ Approved

Clean IDL update adding three new optional fields (AutoForwardingEnabled, TimerTaskInfo.TaskList, TransferTaskInfo.OriginalTaskList) with proper serialization, getters, and round-trip test coverage following established patterns.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@Shaddoll Shaddoll merged commit e3f652e into cadence-workflow:master Feb 19, 2026
89 of 94 checks passed
@Shaddoll Shaddoll deleted the idl branch February 19, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants