Skip to content

feat(domain multi-tenancy): Update Cassandra schema to be synced with recent IDL changes#7727

Merged
Shaddoll merged 1 commit intocadence-workflow:masterfrom
Shaddoll:cql
Feb 19, 2026
Merged

feat(domain multi-tenancy): Update Cassandra schema to be synced with recent IDL changes#7727
Shaddoll merged 1 commit intocadence-workflow:masterfrom
Shaddoll:cql

Conversation

@Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Feb 19, 2026

What changed?
Update Cassandra schema to add original_task_list and task_list to transfer and timer tasks.

Why?
#7724

How did you test it?
N/A

Potential risks
N/A

Release notes
N/A

Documentation Changes
N/A

Detailed Description
Update Cassandra schema to add original_task_list and task_list to transfer and timer tasks.

Impact Analysis

  • Backward Compatibility: Yes
  • Forward Compatibility: Yes

Testing Plan

  • Unit Tests: Yes
  • Persistence Tests: TBD
  • Integration Tests: TBD
  • Compatibility Tests: N/A

Rollout Plan

  • What is the rollout plan?
  • Does the order of deployment matter? No.
  • Is it safe to rollback? Does the order of rollback matter? Yes. No.
  • Is there a kill switch to mitigate the impact immediately? No.

Reviewer Validation

PR Description Quality (check these before reviewing code):

  • "What changed" provides a clear 1-2 line summary
    • Project Issue is linked
  • "Why" explains the full motivation with sufficient context
  • Testing is documented:
    • Unit test commands are included (with exact go test invocation)
    • Integration test setup/commands included (if integration tests were run)
    • Canary testing details included (if canary was mentioned)
  • Potential risks section is thoughtfully filled out (or legitimately N/A)
  • Release notes included if this completes a user-facing feature
  • Documentation needs are addressed (or noted if uncertain)

@gitar-bot
Copy link

gitar-bot bot commented Feb 19, 2026

🔍 CI failure analysis for ad23a15: Five CI failures: (1) breaking-change-pr-template-reminder still missing template, (2) TestWatchLoopDisabled flaky test persisting, (3) NEW: TestQueryWorkflow_DecisionTaskDispatch_Complete query failure, (4-5) cassandra and sqlite integration tests - all test failures appear unrelated to schema changes.

Issue 1: breaking-change-pr-template-reminder (STILL FAILING)

The CI check failed because it detected schema changes but the PR description does not include the required breaking change template.

Issue 2: codecov - TestWatchLoopDisabled (STILL FLAKY - PERSISTING)

Test TestWatchLoopDisabled failed in github.com/uber/cadence/service/sharddistributor/client/spectatorclient at clientimpl_test.go:285 - expected an error but got nil. This flaky test continues to fail across multiple CI runs.

Issue 3: codecov - TestQueryWorkflow_DecisionTaskDispatch_Complete (NEW FAILURE - LIKELY FLAKY)

Test TestEngineSuite/TestQueryWorkflow_DecisionTaskDispatch_Complete failed in github.com/uber/cadence/service/history/engine/engineimpl at history_engine_test.go:947 with error "query does not exist". This appears to be a timing/race condition in the query workflow test.

Issue 4: Golang integration test with running history queue v2 (LIKELY UNRELATED)

Test TestCassandraExecutionManager/TestUpdateDeleteWorkflow failed at executionManagerTest.go:2056 with assertion "Should be true".

Issue 5: Golang integration test with sqlite (INSUFFICIENT DETAILS - LIKELY UNRELATED)

Integration test suite github.com/uber/cadence/host failed after 916.145s.

Details

All test failures appear unrelated to the PR changes:

  • PR modifies: Cassandra schema files (adding original_task_list to transfer_task and task_list to timer_task)
  • Tests fail in: Shard distributor, history engine query workflow, execution manager, and sqlite-based integration tests

The schema changes add nullable fields to task types, which should not affect query dispatch logic, shard distributor behavior, or execution manager operations.

Code Review ✅ Approved 1 resolved / 1 findings

Clean, additive Cassandra schema change following established patterns. Previous comment concern resolved — task_list now has an inline comment. No issues found.

✅ 1 resolved
Quality: Missing inline comment for task_list field in timer_task

📄 schema/cassandra/cadence/schema.cql:170
The new original_task_list field in transfer_task has an inline comment explaining its purpose (-- the original task list of the task if the task is a sticky decision task), but the new task_list field in timer_task has no documentation. Every other field in the timer_task type has an inline comment explaining its purpose. Adding a brief comment would help future developers understand when this field is populated and what it represents (e.g., task list name vs ID, nullable semantics).

Rules ❌ No requirements met

Repository Rules

PR Description Quality Standards: Why section needs full technical context beyond issue link; Potential risks section must address schema change rollback safety and compatibility; How did you test it section should document schema validation steps

1 rule not applicable. Show all rules by commenting gitar display:verbose.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@Shaddoll Shaddoll merged commit ac363d7 into cadence-workflow:master Feb 19, 2026
59 of 67 checks passed
@Shaddoll Shaddoll deleted the cql branch February 19, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants