feat(domain multi-tenancy): Store task list name in history tasks#7744
feat(domain multi-tenancy): Store task list name in history tasks#7744Shaddoll merged 1 commit intocadence-workflow:masterfrom
Conversation
Code Review 👍 Approved with suggestions 0 resolved / 2 findingsWell-structured feature addition that systematically populates task list names across all transfer and timer tasks. Two prior minor findings (comment formatting and missing ephemeral normalization test) remain unresolved but are non-blocking. 💡 Quality: No test coverage for ephemeral task list normalization path📄 service/history/execution/mutable_state_task_generator.go:700 📄 service/history/execution/mutable_state_task_generator_test.go The Since ephemeral normalization is the core novel logic in this PR — it aggregates all ephemeral task lists under a single canonical name to prevent scheduling fragmentation — it would be valuable to have at least one test case that sets A simple unit test for 💡 Quality: Comment continuation lines use spaces instead of tabs📄 common/persistence/tasks.go:44 Lines 44-45 in Compare with lines 47-49 which correctly use tab indentation for the Suggested fixRules
|
| Auto-apply | Compact |
|
|
Was this helpful? React with 👍 / 👎 | Gitar
What changed?
Store task list name in history tasks which will be used to ensure fair scheduling across task lists in history.
Why?
We store the task list property of history tasks so that we can use that property to ensure fair scheduling of history tasks across task lists. This is a part of project #7724
How did you test it?
unit test
cd ./service/history/execution && go test ./...Potential risks
N/A
Release notes
N/A
Documentation Changes
N/A
Reviewer Validation
PR Description Quality (check these before reviewing code):
go testinvocation)