feat: [Cadence Schedules] Add schedule API request/response types#7749
feat: [Cadence Schedules] Add schedule API request/response types#7749abhishekj720 merged 1 commit intomasterfrom
Conversation
Signed-off-by: abhishek.jha <abhishek.jha@uber.com>
c433629 to
53e356a
Compare
Code Review ✅ Approved 1 resolved / 1 findingsPrevious finding (missing Memo/SearchAttributes on Describe and Update types) has been resolved — fields, getters, and test coverage all added. No new issues found in this well-structured, pattern-consistent set of schedule API types. ✅ 1 resolved✅ Bug: Memo/SearchAttributes missing from Describe and Update types
Rules ❌ No requirements metRepository Rules
2 rules not applicable. Show all rules by commenting OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
What changed?
common/types/schedule_service.goScheduleListEntryfor paginated list responseswith existing patterns in
common/types/shared.goschedule_service_test.gowith nil-receiver and value getter testsWhy?
To support the new Cadence Schedules feature (pause/resume, catch-up, backfill), we need internal Go types to represent schedule entities within the server codebase. These types mirror the IDL definitions. This serves as the foundation for the scheduler workflow and API implementation.
Builds on #7745 which introduced the core schedule types and enums.
How did you test it?
Added unit tests and ran go test ./.. on the added files
Potential risks
N/A
Release notes
Added request/response types for cadence schedules
Documentation Changes
N/A
Reviewer Validation
PR Description Quality (check these before reviewing code):
go testinvocation)