fix: [Cadence Schedules] Removing memo as it cannot be updated#7753
Merged
abhishekj720 merged 1 commit intomasterfrom Feb 26, 2026
Merged
fix: [Cadence Schedules] Removing memo as it cannot be updated#7753abhishekj720 merged 1 commit intomasterfrom
abhishekj720 merged 1 commit intomasterfrom
Conversation
Signed-off-by: abhishek.jha <abhishek.jha@uber.com>
Code Review ✅ ApprovedClean removal of the non-updatable Memo field from UpdateScheduleRequest. No callers reference the removed field/method, and the change is consistent with the API constraint that memo cannot be updated. Rules ❌ No requirements metRepository Rules
2 rules not applicable. Show all rules by commenting OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
shijiesheng
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Removing memo as it cannot be updated from UpdateScheduleRequest
Why?
Cannot be updated once created for schedule
Memo is set at StartWorkflowExecution and is immutable. SearchAttributes can be upserted.
How did you test it?
Design phase of feature
Potential risks
N.A.
Release notes
Removing memo as part of updateRequest
Documentation Changes
N/A
Reviewer Validation
PR Description Quality (check these before reviewing code):
go testinvocation)