Skip to content

fix: [Cadence Schedules] Removing memo as it cannot be updated#7753

Merged
abhishekj720 merged 1 commit intomasterfrom
schedule-3
Feb 26, 2026
Merged

fix: [Cadence Schedules] Removing memo as it cannot be updated#7753
abhishekj720 merged 1 commit intomasterfrom
schedule-3

Conversation

@abhishekj720
Copy link
Contributor

@abhishekj720 abhishekj720 commented Feb 26, 2026

What changed?
Removing memo as it cannot be updated from UpdateScheduleRequest

Why?
Cannot be updated once created for schedule
Memo is set at StartWorkflowExecution and is immutable. SearchAttributes can be upserted.

How did you test it?
Design phase of feature

Potential risks
N.A.

Release notes
Removing memo as part of updateRequest

Documentation Changes
N/A

Reviewer Validation

PR Description Quality (check these before reviewing code):

  • "What changed" provides a clear 1-2 line summary
    • Project Issue is linked
  • "Why" explains the full motivation with sufficient context
  • Testing is documented:
    • Unit test commands are included (with exact go test invocation)
    • Integration test setup/commands included (if integration tests were run)
    • Canary testing details included (if canary was mentioned)
  • Potential risks section is thoughtfully filled out (or legitimately N/A)
  • Release notes included if this completes a user-facing feature
  • Documentation needs are addressed (or noted if uncertain)

Signed-off-by: abhishek.jha <abhishek.jha@uber.com>
@gitar-bot
Copy link

gitar-bot bot commented Feb 26, 2026

Code Review ✅ Approved

Clean removal of the non-updatable Memo field from UpdateScheduleRequest. No callers reference the removed field/method, and the change is consistent with the API constraint that memo cannot be updated.

Rules ❌ No requirements met

Repository Rules

PR Description Quality Standards: Add GitHub issue link in summary and release notes, expand Why section with before/after context explaining memo immutability, include exact test commands instead of 'design phase', document breaking API change compatibility risks instead of N/A, and clarify documentation needs

2 rules not applicable. Show all rules by commenting gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@abhishekj720 abhishekj720 enabled auto-merge (squash) February 26, 2026 21:43
@abhishekj720 abhishekj720 merged commit 1d9e012 into master Feb 26, 2026
76 checks passed
@abhishekj720 abhishekj720 deleted the schedule-3 branch February 26, 2026 22:04
@gitar-bot gitar-bot bot mentioned this pull request Feb 26, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants