Skip to content

build: Add cadence-idl dependency with Schedule API support#7756

Merged
abhishekj720 merged 2 commits intomasterfrom
idl-update-2
Feb 27, 2026
Merged

build: Add cadence-idl dependency with Schedule API support#7756
abhishekj720 merged 2 commits intomasterfrom
idl-update-2

Conversation

@abhishekj720
Copy link
Contributor

@abhishekj720 abhishekj720 commented Feb 26, 2026

What changed?
Updates the cadence-idl dependency to include the Schedule API definitions (schedule.proto, service_schedule.proto). This adds the proto types and RPC definitions needed for future Schedule feature work. No Schedule implementation is included in this PR.

  • Bump github.com/uber/cadence-idl to the version that includes Schedule API
  • Update go.mod and go.sum (root and cmd/server)

Why?
This adds the proto types and RPC definitions needed for future Schedule feature work. No Schedule implementation is included in this PR.

How did you test it?
Make pr and build passes
tested by compiling, and running checks: generate, fmt, lint etc.

Potential risks
N/A

Release notes
N/A

Documentation Changes
N/A


Reviewer Validation

PR Description Quality (check these before reviewing code):

  • "What changed" provides a clear 1-2 line summary
    • Project Issue is linked
  • "Why" explains the full motivation with sufficient context
  • Testing is documented:
    • Unit test commands are included (with exact go test invocation)
    • Integration test setup/commands included (if integration tests were run)
    • Canary testing details included (if canary was mentioned)
  • Potential risks section is thoughtfully filled out (or legitimately N/A)
  • Release notes included if this completes a user-facing feature
  • Documentation needs are addressed (or noted if uncertain)

Signed-off-by: abhishek.jha <abhishek.jha@uber.com>
Made-with: Cursor
Signed-off-by: abhishek.jha <abhishek.jha@uber.com>
@abhishekj720 abhishekj720 changed the title Add cadence-idl dependency with Schedule API support feat: Add cadence-idl dependency with Schedule API support Feb 27, 2026
@abhishekj720 abhishekj720 changed the title feat: Add cadence-idl dependency with Schedule API support build: Add cadence-idl dependency with Schedule API support Feb 27, 2026
@gitar-bot
Copy link

gitar-bot bot commented Feb 27, 2026

🔍 CI failure analysis for 785044a: Codecov job failed due to a flaky test in domainCache_test.go, which is unrelated to the IDL dependency changes in this PR.

Issue: Flaky Test Failure in Codecov Job

The codecov CI job failed with a test failure in TestDomainCacheSuite/Test_refreshLoop_domainCacheRefreshedError.

Root Cause

This appears to be a flaky or pre-existing test failure, not related to the changes in this PR. The test is in common/cache/domainCache_test.go, which was not modified.

Details

From the test output:

--- FAIL: TestDomainCacheSuite/Test_refreshLoop_domainCacheRefreshedError (0.01s)
    domainCache_test.go:87: FAIL: GetMetadata(string)
    domainCache_test.go:87: FAIL: 0 out of 1 expectation(s) were met.
        The code you are testing needs to make 1 more call(s).

This is a mock expectation failure - the test expected a call to GetMetadata that didn't occur.

Why this is unrelated to the PR:

  1. This PR only modifies dependency files (go.mod, go.sum) and the IDL submodule
  2. The failing test is in common/cache/domainCache_test.go which is not modified
  3. The test appears to have timing/race condition issues (failed in 0.01s with a mock expectation not met)
  4. There was a successful codecov run for this same branch earlier at 00:17:26Z

Previous Issue Status: PR Title Format

The PR title still does not follow conventional commits format. The title needs a type prefix (e.g., build:, feat:, chore:).

Code Review ✅ Approved

Clean dependency bump for cadence-idl to include Schedule API proto definitions. Both Go modules and the idls submodule are updated consistently to the same commit.

Rules ❌ No requirements met

Repository Rules

PR Description Quality Standards: Link GitHub issue in What changed section; expand Why section with business rationale for Schedule API; provide exact copyable test commands like make pr

2 rules not applicable. Show all rules by commenting gitar display:verbose.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@abhishekj720 abhishekj720 merged commit f409354 into master Feb 27, 2026
76 of 79 checks passed
@abhishekj720 abhishekj720 deleted the idl-update-2 branch February 27, 2026 17:35
abhishekj720 added a commit that referenced this pull request Mar 3, 2026
…/response (#7772)

**What changed?**
Add bidirectional proto mappers (From\*/To\*) for schedule CRUD
request/response types: CreateScheduleRequest/Response,
DescribeScheduleRequest/Response, UpdateScheduleRequest/Response, and
DeleteScheduleRequest/Response.

This is part 3 of the mapper layer for Cadence Schedules (follows
#[7765](#7756),
#[7771](#7771)).

**Why?**
These mappers convert between internal Go types and proto wire format
for schedule CRUD operations. They compose the core type mappers
(ScheduleSpec, ScheduleAction, SchedulePolicies) and state/info mappers
(ScheduleState, ScheduleInfo) from previous PRs into full
request/response structures. They will be used by the gRPC handler layer
for the schedule API.

**How did you test it?**
cd common/types/mapper/proto && go test ./... 

**Potential risks**
Low. These are pure mapping functions with no side effects. 

**Release notes**
N/A

**Documentation Changes**
N/A
---

## Reviewer Validation

**PR Description Quality** (check these before reviewing code):

- [ ] **"What changed"** provides a clear 1-2 line summary
  - [ ] Project Issue is linked
- [ ] **"Why"** explains the full motivation with sufficient context
- [ ] **Testing is documented:**
- [ ] Unit test commands are included (with exact `go test` invocation)
- [ ] Integration test setup/commands included (if integration tests
were run)
  - [ ] Canary testing details included (if canary was mentioned)
- [ ] **Potential risks** section is thoughtfully filled out (or
legitimately N/A)
- [ ] **Release notes** included if this completes a user-facing feature
- [ ] **Documentation** needs are addressed (or noted if uncertain)

Signed-off-by: abhishek.jha <abhishek.jha@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants