build: Add cadence-idl dependency with Schedule API support#7756
build: Add cadence-idl dependency with Schedule API support#7756abhishekj720 merged 2 commits intomasterfrom
Conversation
Signed-off-by: abhishek.jha <abhishek.jha@uber.com>
Made-with: Cursor Signed-off-by: abhishek.jha <abhishek.jha@uber.com>
🔍 CI failure analysis for 785044a: Codecov job failed due to a flaky test in domainCache_test.go, which is unrelated to the IDL dependency changes in this PR.Issue: Flaky Test Failure in Codecov JobThe codecov CI job failed with a test failure in Root CauseThis appears to be a flaky or pre-existing test failure, not related to the changes in this PR. The test is in DetailsFrom the test output: This is a mock expectation failure - the test expected a call to Why this is unrelated to the PR:
Previous Issue Status: PR Title FormatThe PR title still does not follow conventional commits format. The title needs a type prefix (e.g., Code Review ✅ ApprovedClean dependency bump for cadence-idl to include Schedule API proto definitions. Both Go modules and the idls submodule are updated consistently to the same commit. Rules ❌ No requirements metRepository Rules
2 rules not applicable. Show all rules by commenting Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
…/response (#7772) **What changed?** Add bidirectional proto mappers (From\*/To\*) for schedule CRUD request/response types: CreateScheduleRequest/Response, DescribeScheduleRequest/Response, UpdateScheduleRequest/Response, and DeleteScheduleRequest/Response. This is part 3 of the mapper layer for Cadence Schedules (follows #[7765](#7756), #[7771](#7771)). **Why?** These mappers convert between internal Go types and proto wire format for schedule CRUD operations. They compose the core type mappers (ScheduleSpec, ScheduleAction, SchedulePolicies) and state/info mappers (ScheduleState, ScheduleInfo) from previous PRs into full request/response structures. They will be used by the gRPC handler layer for the schedule API. **How did you test it?** cd common/types/mapper/proto && go test ./... **Potential risks** Low. These are pure mapping functions with no side effects. **Release notes** N/A **Documentation Changes** N/A --- ## Reviewer Validation **PR Description Quality** (check these before reviewing code): - [ ] **"What changed"** provides a clear 1-2 line summary - [ ] Project Issue is linked - [ ] **"Why"** explains the full motivation with sufficient context - [ ] **Testing is documented:** - [ ] Unit test commands are included (with exact `go test` invocation) - [ ] Integration test setup/commands included (if integration tests were run) - [ ] Canary testing details included (if canary was mentioned) - [ ] **Potential risks** section is thoughtfully filled out (or legitimately N/A) - [ ] **Release notes** included if this completes a user-facing feature - [ ] **Documentation** needs are addressed (or noted if uncertain) Signed-off-by: abhishek.jha <abhishek.jha@uber.com>
What changed?
Updates the cadence-idl dependency to include the Schedule API definitions (schedule.proto, service_schedule.proto). This adds the proto types and RPC definitions needed for future Schedule feature work. No Schedule implementation is included in this PR.
Why?
This adds the proto types and RPC definitions needed for future Schedule feature work. No Schedule implementation is included in this PR.
How did you test it?
Make pr and build passes
tested by compiling, and running checks: generate, fmt, lint etc.
Potential risks
N/A
Release notes
N/A
Documentation Changes
N/A
Reviewer Validation
PR Description Quality (check these before reviewing code):
go testinvocation)