base patch for 1080p streaming #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires the Caffeine plugin to be built and included.
This addition requires the Caffeine output plugin, as well as the CEF browser integration and will be disabled without it. * COBS-83: Update Signin , ViewOn web links to check if environment variable CAFFEINE_DOMAIN is set, Updated env var to be LIBCAFFEINE_DOMAIN(used in libcaffeine) instead of CAFFEINE_DOMAIN * COBS-51 Crash selecting invalid "Caffeine" entry in docks window, Fixed a Caffeine docks becoming inaccessible. * COBS-75 Incorrect error messages are displayed when clicking on continue after signing-in with a 2FA account and leaving the verification code box empty * COBS-75 Added disabled state button colors * Improved QPushButton focus rect. * Updated the color scheme for disabled button * UI: Fix compatibility for older Qt versions
* COBS-63 Create build script Created Build script with 4 options: -help -check -build -cmbuild build and cmbuild used for configuring and generating project * Updated the README Updated the README to include steps to run automated build script. * Updated README * Updated README Added more details of environment variables to be set * Updated README Included Mac build steps from source * COBS-63 Create Install Script Fixed Errorlevel * Update the script * Update the script
Changed the help link to point to caffeine help center
By moving all audio processing into another thread, we can avoid putting excessive load on the audio thread which isn't expecting this additional work load at all. This fixes the issue where using Caffeine would increase the audio buffer continuously until it couldn't be increased anymore.
…rt Streaming’ without being connected to a Caffeine account (caffeinetv#78)
Added to libcaffeine lib to build for cobs
Squashed commits: [a2e3d01] Fixing deprecated set-env directives from CI [f59fcb4] Removing clang-format tests from Linux [f2cf2b2] Downgrading clang-format on mac to 8 on CI to match Linux version [b4d7668] Updating per ./formatcode.sh (+1 squashed commit) Squashed commits: [fda039b] Update to support newer brew on macOS
* Adding ./bootstrap.sh to help set up OS X build * Renaming to match OS
…emes (caffeinetv#94) Removed the hardcoded stylesheet which now allows the dock window to consume obs-studio theme
* Added sample logger * Removed windows header * Updated CMakeLists.txt * Added video frame window based on latest processed audio sample * Expanded sync window to +-3 Frames at 30fps. Seems to help dropping unneccisarily for small variations * Enhanced logging, set av timestamp to sample range center, drop video packets out of range, stall video pipeline if av desync causes drop * Format code * Updated the functions to work with macos * Formated the code * Fixed build error on windows * Added CAFFEINE_COBS_TEST_FRAME_DROP_PERCENT for dropping testing and dropping a percentage of frames * clang-format ran * added caff_min and caff_max for xp compatibility * clang-format again (caff_min name change put line just over length limit) Co-authored-by: prateekshadas <[email protected]>
* CONTENT-72 Implemented the error messages in cobs * Fix clang formating * Added updated libcaffeine version * Updated CI libcaffeine folder
…netv#97) * COBS-163 Implement copy for error message for system overload * Changed plugin to C++ * Implemented System Overload messaging * Added the Pop up message * Added frames tracking logic in separate files
Fixed Qt DockWiget AllDockWidgetFeature deprecation warning Updated the build scripts for macos
* COBS-167 error message "System under too much load. Broadcast quality may be degraded" occurs when user start streaming in COBS * Clang format update
* COBS-172 Crash occurs when attempting to start a new broadcast after having already broadcast once Fixed deleting of pointer * Fix resetting * Added safe_delete macro and cleanup on caffeine_start and caffeine_end * Fix clang formating Co-authored-by: turbodavidson <[email protected]>
handled bad access when we deleted the FrameTracker on stopping the stream but video thread was still using it
prateekshadas
force-pushed
the
caffeine
branch
from
db8af29 to
6346f4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a basic edit that will allow a user to stream to caffeine at 1080p. This is a followup to the recent announcement that 1080p streaming will be released to users.
This change is