view: unconditionally center views in output layout #278
view: unconditionally center views in output layout #278joggee-fr wants to merge 2 commits intocage-kiosk:masterfrom
Conversation
|
I have just read this quote from the project page:
However with or without the proposed patch, we are able to interact with a background application when also starting a non-maximizable application such as |
|
Looking for opinions. Should we be able to interact with an application in background if it is behind a non-maximizable one? |
I'd say yes, because (1) multiple windows on top of each other is somewhat important to support for dialogs (e.g. open/save window in text editors) and (2) without any kind of visual feedback (like GNOME's dimmed main window when a dialog window is opened) it's hard for the user to understand why input events aren't going through to the window behind. (Alternatively we could dim the window underneath, but this would be a larger change and a bit opinionated.) |
joggee-fr
force-pushed
the
jg/recenter
branch
from
af50b27 to
2c45273
Compare
joggee-fr
changed the title
|
New version now always position all view in the center of the output layout then try to maximize just like before. |
joggee-fr
force-pushed
the
jg/recenter
branch
from
2c45273 to
f493e72
Compare
|
Rebased and added a commit to fix issue #254 considering top left corner declared in window geometry. |
Whatever type or dimensions of a view, position it at center of the output layout. Then, if it is a primary view or if it extends the output layout, send request to maximize it. The client may or may not change the view dimensions after that. If not, e.g. weston-flower, the view will be kept displayed at center instead of to left. If so, the view will expand from center to fill the whole output layout. In order to update the view position, XDG shell surface commit is now handled to check for dimension change.
|
Rebased to current master HEAD. |
2 participants
Some applications e.g.
weston-flowerdoes not really accept to be maximized and kept its surface to a fixed size. In such a case, force the surface to be recentered for a nicer display.This patch is again inspired by what is already done in Sway. However there is a small drawback, the window move can be observed briefly.