Skip to content

Fix segfault when title or app_id is NULL#460

Merged
emersion merged 1 commit intocage-kiosk:masterfrom
yshui-forks:app-id-segv
Dec 18, 2025
Merged

Fix segfault when title or app_id is NULL#460
emersion merged 1 commit intocage-kiosk:masterfrom
yshui-forks:app-id-segv

Conversation

@yshui
Copy link
Contributor

@yshui yshui commented Dec 17, 2025

reproduce: run vkcube

stacktrace:

(gdb) bt
#0  0x0000778f43a8fd9c in __strlen_evex () from /nix/store/xx7cm72qy2c0643cm1ipngd87aqwkcdp-glibc-2.40-66/lib/libc.so.6
#1  0x0000778f439b0e93 in strdup () from /nix/store/xx7cm72qy2c0643cm1ipngd87aqwkcdp-glibc-2.40-66/lib/libc.so.6
#2  0x0000778f43c04932 in wlr_foreign_toplevel_handle_v1_set_app_id () from /nix/store/g0kgs3vprlzmgzig2371j3308y1xnf2z-wlroots-0.19.2/lib/libwlroots-0.19.so
#3  0x00005684811215fd in handle_xdg_toplevel_map (listener=0x5684c0eb2228, data=<optimized out>) at ../xdg_shell.c:229
#4  0x0000778f43caad4c in wl_signal_emit_mutable () from /nix/store/h9grlk1b07l80k6rnmyliawg25bdpsv5-wayland-1.24.0/lib/libwayland-server.so.0
#5  0x0000778f43bfd549 in surface_commit_state () from /nix/store/g0kgs3vprlzmgzig2371j3308y1xnf2z-wlroots-0.19.2/lib/libwlroots-0.19.so
#6  0x0000778f4368d052 in ffi_call_unix64 () from /nix/store/b9p0zpa93hwvh4d0r1rmgc2500yx2ldn-libffi-3.5.2/lib/libffi.so.8
#7  0x0000778f4368b60d in ffi_call_int () from /nix/store/b9p0zpa93hwvh4d0r1rmgc2500yx2ldn-libffi-3.5.2/lib/libffi.so.8
#8  0x0000778f4368c5ae in ffi_call () from /nix/store/b9p0zpa93hwvh4d0r1rmgc2500yx2ldn-libffi-3.5.2/lib/libffi.so.8
#9  0x0000778f43cafabf in wl_closure_invoke () from /nix/store/h9grlk1b07l80k6rnmyliawg25bdpsv5-wayland-1.24.0/lib/libwayland-server.so.0
#10 0x0000778f43ca9dd6 in wl_client_connection_data () from /nix/store/h9grlk1b07l80k6rnmyliawg25bdpsv5-wayland-1.24.0/lib/libwayland-server.so.0
#11 0x0000778f43cad1c2 in wl_event_loop_dispatch () from /nix/store/h9grlk1b07l80k6rnmyliawg25bdpsv5-wayland-1.24.0/lib/libwayland-server.so.0
#12 0x0000778f43caa6d5 in wl_display_run () from /nix/store/h9grlk1b07l80k6rnmyliawg25bdpsv5-wayland-1.24.0/lib/libwayland-server.so.0
#13 0x000056848111dd65 in main (argc=6, argv=0x7ffd6fd59f88) at ../cage.c:622

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emersion emersion merged commit cb8582c into cage-kiosk:master Dec 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants