Support CDN loading for DuckDB WASM#31
Merged
caioricciuti merged 2 commits intocaioricciuti:mainfrom Feb 24, 2026
Merged
Conversation
Owner
|
Merged :) thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a configurable mechanism for loading DuckDB WASM and worker assets, enabling both local and CDN-based deployments.
Key changes:
MANUAL_BUNDLESwithresolveDuckdbBundles, which determines asset sources at runtime based on environment variables.DUCK_UI_DUCKDB_WASM_USE_CDNDUCK_UI_DUCKDB_WASM_BASE_URLDUCK_UI_DUCKDB_WASM_CDN_ONLY, exposed as__DUCK_UI_BUILD_DUCKDB_CDN_ONLY__in Vite, to allow CDN-only builds.createDuckdbWorkerto standardize worker instantiation (including proper URL revocation) and update all DuckDB connection paths to use it.There are no changes to query behavior. This update focuses on making DuckDB WASM asset loading configurable and better suited for edge deployments.