Skip to content

AppBar fixes #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
josuave merged 2 commits into from
Feb 5, 2025
Merged

AppBar fixes #124

josuave merged 2 commits into from
Feb 5, 2025

Conversation

@dremin
Copy link
Collaborator

@dremin dremin commented Feb 5, 2025

  • Get and use window coordinates in pixels instead of converting points to pixels when comparing AppBar rects
  • Save latest AppBar rect in AppBarWindow, so that when multiple updates come quickly, the AppBar window does not bounce around any more due to the timer using stale data.

@dremin dremin requested a review from josuave February 5, 2025 03:42
@josuave josuave merged commit c9425e8 into master Feb 5, 2025
1 check passed
@dremin dremin deleted the appbar-fixes branch February 5, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josuave josuave josuave approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dremin @josuave