AppBar refactoring and improvements #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dremin
commented
Feb 18, 2025
dremin
commented
- Removed the ShowInTaskbar=false from AppBarWindow because all it does is creates a hidden owner window and removes the APPWINDOW style. We already have the TOOLWINDOW style so we don't need an owner to be hidden from the taskbar. Enhanced the helper that sets TOOLWINDOW to also remove APPWINDOW.
- Removed a lot of duplication across AppBarManager and AppBarWindow, mostly around sizing/positioning logic.
- Added a cache of the current window rect to AppBarWindow so that it doesn't have to be fetched as often.
- More consistently use pixels instead of performing math on WPF's points-based size/position values
- Removed the timer-based AppBar positioning hacks in favor of reacting to unexpected WM_WINDOWPOSCHANGED messages instead. Whenever we intentionally update our position, we set a flag, so we only react when something else is doing it, which prevents creating a loop here.
- Added a workaround for this WPF bug
- Fixed a few bugs with mixed DPI.
- Add virtual methods to AppBarWindow that shells can use to modify full screen event handling.
It creates a hidden owner window and removes the APPWINDOW style. We already have the TOOLWINDOW style so we don't need an owner to be hidden from the taskbar.
Deduplicated several code blocks Simplified function calling patterns Cache window rect and reduce points/pixels conversions Remove timer-based hacks in favor of handling window messages Workaround WPF activation bug when DPI changes Fixed a few bugs
josuave
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.