Ignore monitor cache when using TasksService events #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows 8 and newer, as of #123 we use the shell hook messages sent to us when a window moves to another monitor, instead of the global window move event hook that we use on Windows 7.
However, one limitation is that this tells us when the window moves to another monitor, but not necessarily when the monitor it is on is removed. When that happens, the cached HMonitor becomes incorrect.
When the system's displays change, shells that use this value are going to have to handle the display change events anyway to add/remove taskbars, so they will naturally fetch HMonitor from ApplicationWindow.
By ignoring the cached value in this scenario, we always end up with the correct value when it is needed. We still keep the cache around so that we can avoid triggering PropertyChanged events when HMonitor doesn't change.