Improvements to full-screen logic #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dremin
commented
Feb 27, 2025
dremin
commented
- When TasksService receives a full-screen event, trust it more and skip screen bounds checks (but still do the other checks)
- Maintain a list of inactive full-screen windows so that we don't lose state when a new foreground window is activated
- Change bounds check to account for bordered popup windows
- Add heuristic to prevent exiting full-screen when a topmost window is activated on top of a full-screen window, as Windows does
- Related refactors
1. When TasksService receives a full-screen event, trust it and skip window/screen bounds checks 2. Maintain a list of inactive full-screen windows so that we don't lose state when a new foreground window is activated 3. Change bounds check to account for bordered popup windows 4. Related refactors
josuave
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.