Make properties init-only (#392)

pascalberger · web-flow · commit 3fd9aa245ca5 · 2023-01-23T23:19:59.000Z
diff --git a/src/Cake.AzureDevOps/Pipelines/AzureDevOpsArtifactResource.cs b/src/Cake.AzureDevOps/Pipelines/AzureDevOpsArtifactResource.cs
@@ -1,4 +1,5 @@
-﻿namespace Cake.AzureDevOps.Pipelines
+﻿// ReSharper disable UnusedAutoPropertyAccessor.Global
+namespace Cake.AzureDevOps.Pipelines
 {
     using System.Collections.Generic;
     using Cake.Common.Build.AzurePipelines.Data;
diff --git a/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildArtifact.cs b/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildArtifact.cs
@@ -1,4 +1,5 @@
-﻿namespace Cake.AzureDevOps.Pipelines
+﻿// ReSharper disable UnusedAutoPropertyAccessor.Global
+namespace Cake.AzureDevOps.Pipelines
 {
     /// <summary>
     /// Represents an artifact associated with a build.
diff --git a/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildDefinition.cs b/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildDefinition.cs
@@ -1,4 +1,5 @@
-﻿namespace Cake.AzureDevOps.Pipelines
+﻿// ReSharper disable UnusedAutoPropertyAccessor.Global
+namespace Cake.AzureDevOps.Pipelines
 {
     /// <summary>
     /// Representation of a build definition.
diff --git a/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildsSettings.cs b/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildsSettings.cs
@@ -1,4 +1,5 @@
-﻿namespace Cake.AzureDevOps.Pipelines
+﻿// ReSharper disable UnusedAutoPropertyAccessor.Global
+namespace Cake.AzureDevOps.Pipelines
 {
     using System;
     using Cake.AzureDevOps.Authentication;
@@ -53,41 +54,41 @@ public AzureDevOpsBuildsSettings(IAzureDevOpsCredentials credentials)
         }
 
         /// <summary>
-        /// Gets or sets the name of the build definition.
+        /// Gets the name of the build definition.
         /// Can be <c>null</c> or <see cref="string.Empty"/>.
         /// </summary>
-        public string BuildDefinitionName { get; set; }
+        public string BuildDefinitionName { get; init; }
 
         /// <summary>
-        /// Gets or sets the name of the branch.
+        /// Gets the name of the branch.
         /// Can be <c>null</c> or <see cref="string.Empty"/>.
         /// </summary>
-        public string BranchName { get; set; }
+        public string BranchName { get; init; }
 
         /// <summary>
-        /// Gets or sets the build status.
+        /// Gets the build status.
         /// </summary>
-        public AzureDevOpsBuildStatus? BuildStatus { get; set; }
+        public AzureDevOpsBuildStatus? BuildStatus { get; init; }
 
         /// <summary>
-        /// Gets or sets the build result.
+        /// Gets the build result.
         /// </summary>
-        public AzureDevOpsBuildResult? BuildResult { get; set; }
+        public AzureDevOpsBuildResult? BuildResult { get; init; }
 
         /// <summary>
-        /// Gets or sets the build query order.
+        /// Gets the build query order.
         /// </summary>
-        public AzureDevOpsBuildQueryOrder? BuildQueryOrder { get; set; }
+        public AzureDevOpsBuildQueryOrder? BuildQueryOrder { get; init; }
 
         /// <summary>
-        /// Gets or sets the maximum number of builds per definition.
+        /// Gets the maximum number of builds per definition.
         /// </summary>
-        public int? MaxBuildsPerDefinition { get; set; }
+        public int? MaxBuildsPerDefinition { get; init; }
 
         /// <summary>
-        /// Gets or sets the maximum number of builds.
+        /// Gets the maximum number of builds.
         /// </summary>
-        public int? Top { get; set; }
+        public int? Top { get; init; }
 
         /// <summary>
         /// Constructs the settings object using the access token provided by Azure Pipelines.
diff --git a/src/Cake.AzureDevOps/Pipelines/AzureDevOpsChange.cs b/src/Cake.AzureDevOps/Pipelines/AzureDevOpsChange.cs
@@ -1,4 +1,5 @@
-﻿namespace Cake.AzureDevOps.Pipelines
+﻿// ReSharper disable UnusedAutoPropertyAccessor.Global
+namespace Cake.AzureDevOps.Pipelines
 {
     using System;
 
diff --git a/src/Cake.AzureDevOps/Pipelines/AzureDevOpsTestResult.cs b/src/Cake.AzureDevOps/Pipelines/AzureDevOpsTestResult.cs
@@ -1,4 +1,5 @@
-﻿namespace Cake.AzureDevOps.Pipelines
+﻿// ReSharper disable UnusedAutoPropertyAccessor.Global
+namespace Cake.AzureDevOps.Pipelines
 {
     /// <summary>
     /// Represents a test result associated with a <see cref="AzureDevOpsTestRun" />.
diff --git a/src/Cake.AzureDevOps/Pipelines/AzureDevOpsTimelineRecord.cs b/src/Cake.AzureDevOps/Pipelines/AzureDevOpsTimelineRecord.cs
@@ -1,4 +1,5 @@
-﻿namespace Cake.AzureDevOps.Pipelines
+﻿// ReSharper disable UnusedAutoPropertyAccessor.Global
+namespace Cake.AzureDevOps.Pipelines
 {
     using System;
 
diff --git a/src/Cake.AzureDevOps/Repos/AzureDevOpsCommit.cs b/src/Cake.AzureDevOps/Repos/AzureDevOpsCommit.cs
@@ -1,4 +1,5 @@
-﻿namespace Cake.AzureDevOps.Repos
+﻿// ReSharper disable UnusedAutoPropertyAccessor.Global
+namespace Cake.AzureDevOps.Repos
 {
     using System.Collections.Generic;
 
diff --git a/src/Cake.AzureDevOps/Repos/PullRequest/AzureDevOpsPullRequestIterationChange.cs b/src/Cake.AzureDevOps/Repos/PullRequest/AzureDevOpsPullRequestIterationChange.cs
@@ -8,18 +8,18 @@
     public class AzureDevOpsPullRequestIterationChange
     {
         /// <summary>
-        /// Gets or sets the file path the iteration change is associated with.
+        /// Gets the file path the iteration change is associated with.
         /// </summary>
-        public FilePath ItemPath { get; set; }
+        public FilePath ItemPath { get; init; }
 
         /// <summary>
-        /// Gets or sets the id of the iteration change.
+        /// Gets the id of the iteration change.
         /// </summary>
-        public int ChangeId { get; set; }
+        public int ChangeId { get; init; }
 
         /// <summary>
-        /// Gets or sets the tracking id of the iteration change.
+        /// Gets the tracking id of the iteration change.
         /// </summary>
-        public int ChangeTrackingId { get; set; }
+        public int ChangeTrackingId { get; init; }
     }
 }
diff --git a/src/Cake.AzureDevOps/Repos/PullRequest/AzureDevOpsPullRequestSettings.cs b/src/Cake.AzureDevOps/Repos/PullRequest/AzureDevOpsPullRequestSettings.cs
@@ -84,7 +84,7 @@ public AzureDevOpsPullRequestSettings(IAzureDevOpsCredentials credentials)
         /// <summary>
         /// Gets the ID of the pull request.
         /// </summary>
-        public int? PullRequestId { get; private set; }
+        public int? PullRequestId { get; }
 
         /// <summary>
         /// Gets or sets a value indicating whether an exception should be thrown if
diff --git a/src/Cake.AzureDevOps/Repos/PullRequest/AzureDevOpsPullRequestStatus.cs b/src/Cake.AzureDevOps/Repos/PullRequest/AzureDevOpsPullRequestStatus.cs
@@ -1,4 +1,5 @@
-﻿namespace Cake.AzureDevOps.Repos.PullRequest
+﻿// ReSharper disable UnusedAutoPropertyAccessor.Global
+namespace Cake.AzureDevOps.Repos.PullRequest
 {
     using System;
 
@@ -24,23 +25,23 @@ public AzureDevOpsPullRequestStatus(string name)
         public string Name { get; }
 
         /// <summary>
-        /// Gets or sets the genre of the status.
+        /// Gets the genre of the status.
         /// </summary>
-        public string Genre { get; set; }
+        public string Genre { get; init; }
 
         /// <summary>
-        /// Gets or sets the state of the pull request.
+        /// Gets the state of the pull request.
         /// </summary>
-        public AzureDevOpsPullRequestStatusState State { get; set; }
+        public AzureDevOpsPullRequestStatusState State { get; init; }
 
         /// <summary>
-        /// Gets or sets the description of the status.
+        /// Gets the description of the status.
         /// </summary>
-        public string Description { get; set; }
+        public string Description { get; init; }
 
         /// <summary>
-        /// Gets or sets the URL of the status.
+        /// Gets the URL of the status.
         /// </summary>
-        public Uri TargetUrl { get; set; }
+        public Uri TargetUrl { get; init; }
     }
 }
diff --git a/src/Cake.AzureDevOps/Repos/PullRequest/BaseAzureDevOpsPullRequestSettings.cs b/src/Cake.AzureDevOps/Repos/PullRequest/BaseAzureDevOpsPullRequestSettings.cs
@@ -79,7 +79,7 @@ protected BaseAzureDevOpsPullRequestSettings(IAzureDevOpsCredentials credentials
         /// <summary>
         /// Gets the full URL of the Git repository, eg. <code>http://myserver:8080/defaultcollection/myproject/_git/myrepository</code>.
         /// </summary>
-        public Uri RepositoryUrl { get; private set; }
+        public Uri RepositoryUrl { get; }
 
         /// <summary>
         /// Gets the branch for which the pull request is made.
@@ -90,6 +90,6 @@ protected BaseAzureDevOpsPullRequestSettings(IAzureDevOpsCredentials credentials
         /// <summary>
         /// Gets the branch for which the pull request is made.
         /// </summary>
-        public string SourceRefName { get; private set; }
+        public string SourceRefName { get; }
     }
 }
diff --git a/src/Cake.AzureDevOps/Repos/PullRequest/CommentThread/AzureDevOpsComment.cs b/src/Cake.AzureDevOps/Repos/PullRequest/CommentThread/AzureDevOpsComment.cs
@@ -53,30 +53,30 @@ internal AzureDevOpsComment(Comment comment, int threadId)
         public int ThreadId { get; }
 
         /// <summary>
-        /// Gets or sets the content of the pull request comment.
+        /// Gets the content of the pull request comment.
         /// </summary>
         public string Content
         {
             get => this.Comment.Content;
-            set => this.Comment.Content = value;
+            init => this.Comment.Content = value;
         }
 
         /// <summary>
-        /// Gets or sets a value indicating whether the comment is deleted.
+        /// Gets a value indicating whether the comment is deleted.
         /// </summary>
         public bool IsDeleted
         {
             get => this.Comment.IsDeleted;
-            set => this.Comment.IsDeleted = value;
+            init => this.Comment.IsDeleted = value;
         }
 
         /// <summary>
-        /// Gets or sets the comment type.
+        /// Gets the comment type.
         /// </summary>
         public AzureDevOpsCommentType CommentType
         {
             get => (AzureDevOpsCommentType)this.Comment.CommentType;
-            set => this.Comment.CommentType = (CommentType)value;
+            init => this.Comment.CommentType = (CommentType)value;
         }
 
         /// <summary>
diff --git a/src/Cake.AzureDevOps/Repos/PullRequest/CommentThread/AzureDevOpsPullRequestCommentThread.cs b/src/Cake.AzureDevOps/Repos/PullRequest/CommentThread/AzureDevOpsPullRequestCommentThread.cs

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`		`-namespace Cake.AzureDevOps.Pipelines`
	`1`	`+// ReSharper disable UnusedAutoPropertyAccessor.Global`
	`2`	`+namespace Cake.AzureDevOps.Pipelines`
`2`	`3`	`{`
`3`	`4`	`using System.Collections.Generic;`
`4`	`5`	`using Cake.Common.Build.AzurePipelines.Data;`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`		`-namespace Cake.AzureDevOps.Repos`
	`1`	`+// ReSharper disable UnusedAutoPropertyAccessor.Global`
	`2`	`+namespace Cake.AzureDevOps.Repos`
`2`	`3`	`{`
`3`	`4`	`using System.Collections.Generic;`
`4`	`5`