Skip to content

(GH-117) Add support for npm dist-tag#102

Closed
Kuinox wants to merge 1 commit intocake-contrib:developfrom
Kuinox:develop
Closed

(GH-117) Add support for npm dist-tag#102
Kuinox wants to merge 1 commit intocake-contrib:developfrom
Kuinox:develop

Conversation

@Kuinox
Copy link
Copy Markdown

@Kuinox Kuinox commented Apr 28, 2019

Hi,
I needed to add dist-tag, get the npm config and view pushed packages so i made these commands.

Fixes #117

@pascalberger pascalberger self-requested a review July 14, 2020 09:01
@pascalberger pascalberger linked an issue Aug 29, 2020 that may be closed by this pull request
@pascalberger pascalberger force-pushed the develop branch 4 times, most recently from c97a047 to c7f5ec2 Compare August 29, 2020 10:05
@pascalberger
Copy link
Copy Markdown
Member

@Kuinox Thank you for your contribution. I would like to include the three features in separate pull requests. I therefore split this PR into #122 and #123 and will keep this for implementing support for npm dist-tag.

@pascalberger pascalberger changed the title Added commands for npm dist-tag, view, get (GH-117) Add support for npm dist-tag Aug 29, 2020
Copy link
Copy Markdown
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having an enum in the settings (and some settings which don't make sense depending on the selected command), I would prefer to have separate aliases for the different calls. Also should contain test cases, documentation of the whole public API and code style consistent with the project.

@pascalberger pascalberger force-pushed the develop branch 2 times, most recently from 1e2d419 to 332429b Compare September 6, 2020 20:27
@Kuinox Kuinox closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for npm dist-tag command

2 participants