Skip to content

Xcode 14.2 support#482

Open
IlyaBausovAkvelon wants to merge 18 commits intodevelopfrom
feature/xcode-14-2-ios-16-support
Open

Xcode 14.2 support#482
IlyaBausovAkvelon wants to merge 18 commits intodevelopfrom
feature/xcode-14-2-ios-16-support

Conversation

@IlyaBausovAkvelon
Copy link
Copy Markdown
Contributor

No description provided.

@DmitriyKirakosyan
Copy link
Copy Markdown

@IlyaBausovAkvelon Carthage/Build shouldn't be tracked in the repository.

@@ -75,15 +75,6 @@
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<MacroExpansion>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was it removed?

@@ -241,8 +241,8 @@ - (id) init {


LPASLLogFormatter *ASLLogFormatter = [LPASLLogFormatter new];
[[LPASLLogger sharedInstance] setLogFormatter:ASLLogFormatter];
[LPLog addLogger:[LPASLLogger sharedInstance]];
//[[LPASLLogger sharedInstance] setLogFormatter:ASLLogFormatter];
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why commented?

#import <libkern/OSAtomic.h>

static NSString *const CalLogFormatterDateFormat = @"yyyy-MM-dd HH:mm:ss.SSS";
static NSString *const CalLogFormatterDateFormatterKey = @"sh.calaba.CalSSO-CalLogFormatter-NSDateFormatter";
@interface LPTTYLogFormatter () {
int32_t atomicLoggerCount;
atomic_int_fast32_t atomicLoggerCount;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you share your thoughts on this decision? why need to change old type and why it should be changed to this type?


NSArray *results = [NSArray arrayWithArray:messages];

- (NSDictionary *) JSONResponseForMethod:(NSString *) method URI:(NSString *) path data:(NSDictionary *) data {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this code removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants