Skip to content

fix: use cross-platform rimraf for build scripts#25814

Merged
anikdhabal merged 6 commits intocalcom:mainfrom
Anshumancanrock:cross-platform-script
Jan 12, 2026
Merged

fix: use cross-platform rimraf for build scripts#25814
anikdhabal merged 6 commits intocalcom:mainfrom
Anshumancanrock:cross-platform-script

Conversation

@Anshumancanrock
Copy link
Contributor

What does this PR do?

This PR fixes the build failure on Windows by replacing Unix-specific rm -rf commands with cross-platform npx rimraf.

Visual Demo (For contributors especially)

  • Before:
Screenshot 2025-12-12 111850
  • After :
Recording.2025-12-12.111305.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Run yarn to install dependencies
  2. Verify installation completes without errors

@Anshumancanrock Anshumancanrock requested a review from a team December 12, 2025 06:02
@Anshumancanrock Anshumancanrock requested a review from a team as a code owner December 12, 2025 06:02
@vercel
Copy link

vercel bot commented Dec 12, 2025

@Anshumancanrock is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 12, 2025
@github-actions github-actions bot added the 🐛 bug Something isn't working label Dec 12, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

cshein45

This comment was marked as off-topic.

@Anshumancanrock
Copy link
Contributor Author

@cshein45 I think your comment might have been meant for a different issue/PR. This PR is specifically about fixing Windows build failures by replacing rm -rf with cross-platform npx rimraf.

Happy to help with the Movement Lab booking redirect feature if you'd like me to look into it separately! Just let me know.

@github-actions
Copy link
Contributor

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

@github-actions github-actions bot added the Stale label Dec 25, 2025
Copy link
Contributor

@pallava-joshi pallava-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approach is correct, but shouldn't the fix be applied consistently across all package.json?

  • packages/platform/libraries/package.json (2 occurrences)
  • packages/embeds/embed-react/package.json (2 occurrences)
  • packages/embeds/embed-core/package.json (2 occurrences)
  • packages/embeds/embed-snippet/package.json (2 occurrences)

can you dive a lil deeper into it.

@pallava-joshi pallava-joshi marked this pull request as draft January 8, 2026 12:40
@Anshumancanrock Anshumancanrock marked this pull request as ready for review January 9, 2026 09:29
@Anshumancanrock Anshumancanrock requested a review from a team as a code owner January 9, 2026 09:29
@Anshumancanrock
Copy link
Contributor Author

@pallava-joshi You're right, Initially I only replaced the main build commands since those were the ones failing during yarn build. The build succeeded after that, so I didn't dig deeper. We should definitely apply this consistently across all package.json files. I've now updated rm -rf commands with npx rimraf across all scripts.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/embeds/embed-react/package.json">

<violation number="1" location="packages/embeds/embed-react/package.json:14">
P1: The `cp` command is also Unix-specific and will fail on Windows, defeating the purpose of this cross-platform fix. Consider using `npx shx cp` or `npx copyfiles` for cross-platform file copying.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jan 9, 2026
@github-actions github-actions bot removed the Stale label Jan 12, 2026
volnei
volnei previously approved these changes Jan 12, 2026
Copy link
Contributor

@volnei volnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@volnei volnei dismissed their stale review January 12, 2026 14:00

Asked by Keith

@keithwillcode keithwillcode added the run-ci Approve CI to run for external contributors label Jan 12, 2026
@keithwillcode keithwillcode added this to the v6.1 milestone Jan 12, 2026
@anikdhabal anikdhabal merged commit 5c9a5c5 into calcom:main Jan 12, 2026
73 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e run-ci Approve CI to run for external contributors size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails on Windows: 'rm' is not recognized

6 participants