fix: use cross-platform rimraf for build scripts#25814
fix: use cross-platform rimraf for build scripts#25814anikdhabal merged 6 commits intocalcom:mainfrom
Conversation
|
@Anshumancanrock is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
@cshein45 I think your comment might have been meant for a different issue/PR. This PR is specifically about fixing Windows build failures by replacing Happy to help with the Movement Lab booking redirect feature if you'd like me to look into it separately! Just let me know. |
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
pallava-joshi
left a comment
There was a problem hiding this comment.
approach is correct, but shouldn't the fix be applied consistently across all package.json?
packages/platform/libraries/package.json(2 occurrences)packages/embeds/embed-react/package.json(2 occurrences)packages/embeds/embed-core/package.json(2 occurrences)packages/embeds/embed-snippet/package.json(2 occurrences)
can you dive a lil deeper into it.
|
@pallava-joshi You're right, Initially I only replaced the main build commands since those were the ones failing during yarn build. The build succeeded after that, so I didn't dig deeper. We should definitely apply this consistently across all |
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/embeds/embed-react/package.json">
<violation number="1" location="packages/embeds/embed-react/package.json:14">
P1: The `cp` command is also Unix-specific and will fail on Windows, defeating the purpose of this cross-platform fix. Consider using `npx shx cp` or `npx copyfiles` for cross-platform file copying.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
68087ac to
2ec9a77
Compare
What does this PR do?
This PR fixes the build failure on Windows by replacing Unix-specific
rm -rfcommands with cross-platformnpx rimraf.Visual Demo (For contributors especially)
Recording.2025-12-12.111305.mp4
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
yarnto install dependencies