-
Notifications
You must be signed in to change notification settings - Fork 11.5k
refactor(ui): remove unused components and exports #26222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui): remove unused components and exports #26222
Conversation
|
@abhayymishraa is attempting to deploy a commit to the cal-staging Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 18 files
4f2ca03 to
f60b716
Compare
|
@abhayymishraa thank you for your contribution! While the PR looks good I want to understand why did you use a force-push? |
volnei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question on PR
|
@volnei, by mistake, i added some other changes in |
Yes, looks like he accidentally pushed openapi file changes from other branch/pr : commit |
dhairyashiil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for your contribution
What does this PR do?
This PR removes unused components and exports from the UI package to reduce codebase size and improve maintainability. All removed components were verified to have zero imports or usage in the codebase.
Components Removed:
UpgradeOrgsBadge- Badge component with no usageInputFieldWithSelect- Form component only used in testsStepper- Step component with no usageFormStep- Step component with no usageRangeSlider- Slider component with no usageRangeSliderPopover- Slider component with no usageSlider- Slider component (misnamed index.tsx file) with no usageNavigationItem- Navigation component from UI package (different from shell NavigationItem)AddressInputNonLazy- Address component export (only used in removed test file)Exports Removed:
HintsOrErrorsexport (component kept, used internally by TextField)FieldsetLegend,InputGroupBox,InputLeadingfrom form inputsDropdownMenuRadioGroup,DropdownMenuRadioItem,DropdownMenuGroup,DropdownMenuTriggerItemfrom dropdownTest Files Cleaned:
BookingFields.test.tsxthat usedAddressInputNonLazyinput.test.tsxto removeInputFieldWithSelecttestImpact:
Visual Demo (For contributors especially)
N/A - This is a code cleanup PR with no visual changes. All removed components were unused and had no impact on the UI.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Verification Steps:
yarn type-check:ci --forceto ensure no type errorsyarn lint:fixto ensure no linting errorsyarn buildyarn testWhat was verified:
HintsOrErrorsstill used byTextField)Expected Result:
Checklist
yarn lint:fixandyarn type-check:ci --force