-
Notifications
You must be signed in to change notification settings - Fork 11.7k
chore: Make atoms cache-key more reusable #26384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
| path: | | ||
| **/dist/** | ||
| key: ${{ runner.os }}-${{ env.cache-name }}-${{ env.key-1 }}-${{ env.key-2 }}-${{ env.key-3 }}-${{ env.key-4 }} | ||
| - name: Log Cache Hit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An extra step for logging the cache hit is not necessary because the cache action itself tells you this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
volnei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better
Summary by cubic
Simplified the atoms production build cache key to improve reuse across branches and commits and speed up CI builds. The key now hashes yarn.lock, atoms source files, and the atoms package.json, and drops OS-, PR-, and commit-specific values.
Written for commit 0aac310. Summary will update on new commits.