-
Notifications
You must be signed in to change notification settings - Fork 11.5k
refactor(companion): event type details screen improvements #26415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(companion): event type details screen improvements #26415
Conversation
|
@betomoedano is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
…and EventTypeDetail components
…TypeDetail component
…TypeDetail component
…TypeDetail component
…TypeDetail component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="companion/app/(tabs)/(event-types)/event-type-detail.tsx">
<violation number="1" location="companion/app/(tabs)/(event-types)/event-type-detail.tsx:1151">
P1: Missing back/close button for iOS users. The `Stack.Header.Left` with the close button was removed, but `headerShown` is false on iOS so the custom `Stack.Header` is the only navigation. Consider adding a back button to `Stack.Header.Left` or relying on a system back gesture.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
|
||
| <Stack.Header.Title>{headerTitle}</Stack.Header.Title> | ||
|
|
||
| <Stack.Header blurEffect={isLiquidGlassAvailable() ? undefined : "light"}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: Missing back/close button for iOS users. The Stack.Header.Left with the close button was removed, but headerShown is false on iOS so the custom Stack.Header is the only navigation. Consider adding a back button to Stack.Header.Left or relying on a system back gesture.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At companion/app/(tabs)/(event-types)/event-type-detail.tsx, line 1151:
<comment>Missing back/close button for iOS users. The `Stack.Header.Left` with the close button was removed, but `headerShown` is false on iOS so the custom `Stack.Header` is the only navigation. Consider adding a back button to `Stack.Header.Left` or relying on a system back gesture.</comment>
<file context>
@@ -1141,20 +1141,44 @@ export default function EventTypeDetail() {
-
- <Stack.Header.Title>{headerTitle}</Stack.Header.Title>
-
+ <Stack.Header blurEffect={isLiquidGlassAvailable() ? undefined : "light"}>
<Stack.Header.Right>
+ <Stack.Header.Menu>
</file context>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🔥
What does this PR do?
This PR improves the event type details screen using a context menu for iOS and also removes the bottom actions view in favor of adding those features inside the scroll view for a cleaner UI.
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Summary by cubic
Refactored the Event Type Detail screen to use an iOS header menu for tab switching and registered the new route. This streamlines navigation, cleans up the UI, and improves content layout.
UI Improvements
Refactors
Written for commit 98e7b25. Summary will update on new commits.