Skip to content

Conversation

@betomoedano
Copy link
Contributor

@betomoedano betomoedano commented Jan 3, 2026

What does this PR do?

This PR improves the event type details screen using a context menu for iOS and also removes the bottom actions view in favor of adding those features inside the scroll view for a cleaner UI.

Image Demo (if applicable):

image image

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Run the app and navigate to the event type details screen

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by cubic

Refactored the Event Type Detail screen to use an iOS header menu for tab switching and registered the new route. This streamlines navigation, cleans up the UI, and improves content layout.

  • UI Improvements

    • Added a transparent iOS header with a tab menu and Save button.
    • Converted the bottom action bar into an in-content action card with preview, copy link, and delete.
    • Enabled automatic content inset adjustment for smoother scrolling.
  • Refactors

    • Moved EventTypeDetail to its own file and registered the "event-type-detail" route; kept platform-specific header behavior.

Written for commit 98e7b25. Summary will update on new commits.

@vercel
Copy link

vercel bot commented Jan 3, 2026

@betomoedano is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@betomoedano betomoedano marked this pull request as ready for review January 3, 2026 16:28
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 3, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="companion/app/(tabs)/(event-types)/event-type-detail.tsx">

<violation number="1" location="companion/app/(tabs)/(event-types)/event-type-detail.tsx:1151">
P1: Missing back/close button for iOS users. The `Stack.Header.Left` with the close button was removed, but `headerShown` is false on iOS so the custom `Stack.Header` is the only navigation. Consider adding a back button to `Stack.Header.Left` or relying on a system back gesture.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.


<Stack.Header.Title>{headerTitle}</Stack.Header.Title>

<Stack.Header blurEffect={isLiquidGlassAvailable() ? undefined : "light"}>
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Missing back/close button for iOS users. The Stack.Header.Left with the close button was removed, but headerShown is false on iOS so the custom Stack.Header is the only navigation. Consider adding a back button to Stack.Header.Left or relying on a system back gesture.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At companion/app/(tabs)/(event-types)/event-type-detail.tsx, line 1151:

<comment>Missing back/close button for iOS users. The `Stack.Header.Left` with the close button was removed, but `headerShown` is false on iOS so the custom `Stack.Header` is the only navigation. Consider adding a back button to `Stack.Header.Left` or relying on a system back gesture.</comment>

<file context>
@@ -1141,20 +1141,44 @@ export default function EventTypeDetail() {
-
-          &lt;Stack.Header.Title&gt;{headerTitle}&lt;/Stack.Header.Title&gt;
-
+        &lt;Stack.Header blurEffect={isLiquidGlassAvailable() ? undefined : &quot;light&quot;}&gt;
           &lt;Stack.Header.Right&gt;
+            &lt;Stack.Header.Menu&gt;
</file context>
Fix with Cubic

Copy link
Member

@dhairyashiil dhairyashiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@dhairyashiil dhairyashiil added the run-ci Approve CI to run for external contributors label Jan 3, 2026
@dhairyashiil dhairyashiil enabled auto-merge (squash) January 3, 2026 17:53
@dhairyashiil dhairyashiil merged commit 285f161 into calcom:main Jan 3, 2026
53 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync ready-for-e2e run-ci Approve CI to run for external contributors size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants