Skip to content

Conversation

@KartikLabhshetwar
Copy link
Contributor

@KartikLabhshetwar KartikLabhshetwar commented Jan 3, 2026

What does this PR do?

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Image Demo (if applicable):

before:
Screenshot 2026-01-03 at 9 05 01 PM

after:

Screenshot 2026-01-03 at 8 44 59 PM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Summary by cubic

Adds vertical spacing between options in the LocationSelect dropdown to clearly separate items on hover and improve readability. Addresses CAL-7015 and #26418.

  • Bug Fixes
    • Adds option class "mb-1 last:mb-0" via innerClassNames for consistent spacing.
    • Extracts innerClassNames from props and merges safely; passes the rest to Select to avoid conflicts.

Written for commit 0dba88d. Summary will update on new commits.

@vercel
Copy link

vercel bot commented Jan 3, 2026

@KartikLabhshetwar is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the 🐛 bug Something isn't working label Jan 3, 2026
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 3, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Member

@dhairyashiil dhairyashiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhairyashiil dhairyashiil added the run-ci Approve CI to run for external contributors label Jan 3, 2026
@dhairyashiil dhairyashiil enabled auto-merge (squash) January 3, 2026 21:25
@dhairyashiil dhairyashiil merged commit c6e74e6 into calcom:main Jan 3, 2026
61 of 68 checks passed
@KartikLabhshetwar KartikLabhshetwar deleted the fix/location-select-option-spacing branch January 4, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e run-ci Approve CI to run for external contributors size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hover spacing between options in LocationSelect dropdown

2 participants