Merged
Conversation
|
@Adarsh9977 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Adarsh9977
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
anikdhabal
previously approved these changes
Jan 5, 2026
Removed unnecessary props from the data table component.
anikdhabal
previously requested changes
Jan 5, 2026
Comment on lines
+371
to
+373
| paginationMode="standard" | ||
| headerClassName="hidden" | ||
| variant="compact" |
Contributor
There was a problem hiding this comment.
only this change isn't sufficient, we need to update the backend logic also
Contributor
Author
There was a problem hiding this comment.
Sure @anikdhabal, keeping this PR only for unhide header. I'll create another PR for pagination.
auto-merge was automatically disabled
January 5, 2026 05:53
Pull request was converted to draft
Contributor
Author
|
@anikdhabal add the pagination changes in #26494 with all the changes |
dhairyashiil
changed the title
dhairyashiil
reviewed
Jan 6, 2026
dhairyashiil
reviewed
Jan 6, 2026
| totalRowCount={totalRowCount} | ||
| tableContainerRef={tableContainerRef} | ||
| paginationMode="infinite" | ||
| variant="compact" |
dhairyashiil
reviewed
Jan 6, 2026
apps/web/modules/settings/outOfOffice/OutOfOfficeEntriesList.tsx
Outdated
Show resolved
Hide resolved
keithwillcode
approved these changes
Jan 13, 2026
keithwillcode
dismissed stale reviews from dhairyashiil and anikdhabal
Addressed
dhairyashiil
added
run-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Screen.Recording.2026-01-05.at.2.30.34.AM.mov
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist