Skip to content

fix: add fallback for ref parameter in cache-checkout action#26703

Merged
anikdhabal merged 1 commit intomainfrom
devin/fix-cache-checkout-ref-fallback-1768073421
Jan 10, 2026
Merged

fix: add fallback for ref parameter in cache-checkout action#26703
anikdhabal merged 1 commit intomainfrom
devin/fix-cache-checkout-ref-fallback-1768073421

Conversation

@keithwillcode
Copy link
Contributor

What does this PR do?

Addresses feedback from cubic's review on PR #26702.

The cache-checkout action's fallback checkout step was missing a fallback for the ref parameter, which would break the action in non-PR contexts (e.g., workflow_dispatch). The cache key already correctly uses ${{ github.event.pull_request.head.sha || github.sha }} but the checkout ref lacked the same fallback.

This PR adds the || github.sha fallback to match the cache key pattern.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - CI workflow changes only.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works. N/A - CI workflow changes can only be tested by running the actual CI pipeline.

How should this be tested?

  1. Trigger a workflow that uses cache-checkout via workflow_dispatch (non-PR context)
  2. Verify the checkout step succeeds using github.sha as the fallback ref

Checklist

  • My code follows the style guidelines of this project
  • I have checked if my changes generate no new warnings

Human Review Checklist

  • Verify the fallback || github.sha is appropriate for all workflow contexts where this action is used
  • Confirm the pattern matches the cache key on line 15

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@keithwillcode keithwillcode marked this pull request as ready for review January 10, 2026 19:31
@keithwillcode keithwillcode requested a review from a team as a code owner January 10, 2026 19:31
@keithwillcode keithwillcode self-assigned this Jan 10, 2026
@keithwillcode keithwillcode added this to the v6.1 milestone Jan 10, 2026
@graphite-app graphite-app bot added foundation core area: core, team members only labels Jan 10, 2026
@keithwillcode keithwillcode added ready-for-e2e and removed core area: core, team members only foundation labels Jan 10, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@anikdhabal anikdhabal enabled auto-merge (squash) January 10, 2026 19:33
@anikdhabal anikdhabal merged commit 3dd0b2d into main Jan 10, 2026
79 of 81 checks passed
@anikdhabal anikdhabal deleted the devin/fix-cache-checkout-ref-fallback-1768073421 branch January 10, 2026 19:37
Anshumancanrock pushed a commit to Anshumancanrock/cal.com that referenced this pull request Jan 12, 2026
…26703)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – cal-companion January 13, 2026 08:23 Inactive
@vercel vercel bot temporarily deployed to Preview – dev January 13, 2026 08:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants