fix: add global CRM services mock to prevent test flakes

[keithwillcode]

What does this PR do?

Fixes flaky unit test failures caused by pending fetch requests during test teardown. Multiple tests were intermittently failing with the error:

[vitest-worker]: Closing rpc while "fetch" was pending

Root cause: The import chain through EventManager → CrmManager → getCrm → crm.apps.generated loads the Salesforce CRM service, which imports @urql/core. This GraphQL client library can trigger fetch calls that remain pending when the Vitest worker shuts down. The error message shows whichever module was being loaded at shutdown time (e.g., routing-forms, watchlist), but the actual culprit is the Salesforce GraphQL client.

Fix: Add a global mock for CrmServiceMap in setupVitest.ts (similar to how payment services are already mocked). This prevents all CRM modules from being loaded during test execution, fixing the flakiness across all affected tests.

• Fixes unit test flakes from https://github.com/calcom/cal.com/actions/runs/20892642118?pr=26714
• Also addresses flakes from:
  • https://github.com/calcom/cal.com/actions/runs/20789670474/job/59709192676?pr=26553
  • https://github.com/calcom/cal.com/actions/runs/20788804672/job/59706558825?pr=26549
  • https://github.com/calcom/cal.com/actions/runs/20789890892/job/59709922559?pr=26555

Changes

• Added MockCrmService class in setupVitest.ts with stub implementations
• Added global mock for @calcom/app-store/crm.apps.generated covering all CRM integrations (closecom, hubspot, pipedrive-crm, salesforce, zoho-bigin, zohocrm)
• Removed redundant comment in handlePaymentSuccess.test.ts

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - test infrastructure change only.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

1. Run the unit tests: TZ=UTC yarn test packages/app-store/_utils/payments/handlePaymentSuccess.test.ts
2. Run the full unit test suite multiple times to verify no flakiness: TZ=UTC yarn test
3. Verify CI passes without the "Closing rpc while fetch was pending" error

Local verification completed:

• All 407 app-store tests pass
• All 529 bookings tests pass (including EventManager.test.ts)

Human Review Checklist

• Verify the mock structure (Promise.resolve({ default: MockCrmService })) matches the dynamic import pattern used in crm.apps.generated.ts
• Confirm no existing tests rely on actual CRM service behavior that would be broken by this mock
• Note: Integration tests are excluded from this mock via the existing !process.env.INTEGRATION_TESTS check

Checklist

• My code follows the style guidelines of this project
• I have checked if my changes generate no new warnings

---

Requested by: @keithwillcode
Link to Devin run: https://app.devin.ai/sessions/94298285724d485caebcd8e8b39beab4

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR that start with 'DevinAI' or '@devin'.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[cubic-dev-ai]

No issues found across 1 file