fix: return 400 instead of 500 for invalid eventTypeId in booking flow#26732
Merged
keithwillcode merged 3 commits intomainfrom Jan 12, 2026
Merged
Conversation
Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
hbjORbj
commented
Jan 12, 2026
Comment on lines
+39
to
+42
| throw new ErrorWithCode( | ||
| ErrorCode.BadRequest, | ||
| `Invalid eventTypeId: ${eventTypeId}. Must be a positive integer.` | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
This gets converted to HttpError later:
BotDetectionServicethrowsErrorWithCode(ErrorCode.BadRequest, "Invalid eventTypeId...")defaultRespondercatches the error and callsgetServerErrorFromUnknown()getServerErrorFromUnknowndetectsErrorWithCodeand callsgetHttpStatusCode(cause)getHttpStatusCodemapsErrorCode.BadRequestto status 400- Response is sent with status 400
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…ests Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
keithwillcode
approved these changes
Jan 12, 2026
keithwillcode
deleted the
devin/fix-eventTypeId-validation-400-1768208791
branch
Anshumancanrock
pushed a commit
to Anshumancanrock/cal.com
that referenced
this pull request
Jan 12, 2026
calcom#26732) * fix: return 400 instead of 500 for invalid eventTypeId in booking flow Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * refactor: use ErrorWithCode instead of HttpError in BotDetectionService Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * refactor: use vi.stubEnv for safer environment variable handling in tests Co-Authored-By: benny@cal.com <sldisek783@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes SQL injection attempts on the booking endpoint (
/api/book/event) returning 500 errors instead of 400.When invalid
eventTypeIdvalues (like SQL injection strings) are passed to the booking endpoint, theBotDetectionService.checkBotDetection()method was throwing a genericError, which resulted in a 500 Internal Server Error. This PR changes it to throw anHttpErrorwith statusCode 400, properly indicating a bad request.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Unit tests have been added covering: