Conversation
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/api/v2/src/main.ts">
<violation number="1" location="apps/api/v2/src/main.ts:86">
P2: Replace console.log with logger.log for consistency with the logging framework</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
Address Cubic AI review feedback to use the logging framework consistently instead of console.log in the serverless handler. Co-Authored-By: unknown <>
Devin AI is resolving merge conflictsThis PR has merge conflicts with the Devin will:
If you prefer to resolve conflicts manually, you can close the Devin session and handle it yourself. |
Resolve merge conflict in biome.json by accepting main branch's broader trpc import restrictions for atoms package. Co-Authored-By: unknown <>
…roxy/github.com/calcom/cal.com into deploy-api-v2-vercel
hariombalhara
left a comment
There was a problem hiding this comment.
We need to be sure with comma:true otherwise okay
E2E results are ready! |
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/api/v2/src/bootstrap.ts">
<violation number="1">
P1: Shutdown hooks are now incorrectly enabled on Vercel. The code change contradicts both the PR description and serverless best practices. According to NestJS documentation, `enableShutdownHooks()` should NOT be called in serverless environments like Vercel/Lambda because shutdown hooks rely on system signals that don't work properly in serverless contexts. This could cause runtime issues, execution timeouts, or improper lifecycle management. Revert to the conditional check or invert the logic to disable shutdown hooks on Vercel.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Devin AI is addressing Cubic AI's review feedbackNew feedback has been sent to the existing Devin session. |
Wrap usePool with JSON.stringify() to properly serialize the string value. Without this, Vite injects the raw value as an identifier instead of a string literal, breaking runtime behavior. Addresses Cubic AI review feedback (confidence 9/10) Co-Authored-By: unknown <>
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/api/v2/Dockerfile">
<violation number="1" location="apps/api/v2/Dockerfile:22">
P1: Build order violation: platform-libraries is built before its dependencies. The dev:build script in apps/api/v2/package.json shows the correct order: constants → enums → utils → types → libraries → trpc. Move the builds for platform-constants, platform-enums, platform-utils, and platform-types to occur BEFORE the platform-libraries build in the Dockerfile.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Devin AI is addressing Cubic AI's review feedbackNew feedback has been sent to the existing Devin session. |
Reorder builds to match the dependency graph from dev:build script: constants → enums → utils → types → libraries → trpc → api-v2 platform-libraries depends on the other platform packages, so they must be built first. Addresses Cubic AI review feedback (confidence 9/10) Co-Authored-By: unknown <>
Devin AI is resolving merge conflictsThis PR has merge conflicts with the Devin will:
If you prefer to resolve conflicts manually, you can close the Devin session and handle it yourself. |
Resolved conflict in turbo.json by keeping both: - PR's API-related environment variables - Main's B2 storage-related environment variables Co-Authored-By: unknown <>
|
Waiting for next release before merging |
Mandatory Tasks (DO NOT REMOVE)
Updates since last revision
console.logwithlogger.login the Vercel serverless handler (line 86) to address Cubic AI review feedback about using the logging framework consistentlySummary by cubic
Deploy API v2 on Vercel by adding a serverless handler with a cached Nest app and adjusting boot logic. Local development startup remains unchanged.
New Features
Refactors
Written for commit 83914bc. Summary will update on new commits.
Link to Devin run: https://app.devin.ai/sessions/c1e01c049b2c42f98010428232035889
Requested by: unknown ()