Conversation
|
Paragon Review Unavailable Hi @pumfleet! To enable Paragon reviews on this repository, please register at https://home.polarity.cc Once registered, connect your GitHub account and Paragon will automatically review your pull requests. |
CarinaWolli
left a comment
CarinaWolli
left a comment
There was a problem hiding this comment.
- Is there a way to get back to the home screen after clicking an item? I think there should be
- Coming from the dropdown doesn't open the home screen and goes directly to /settings/my-account/general
| titleKey: "members", | ||
| descriptionKey: "settings_home_org_members_description", | ||
| icon: "users", | ||
| href: "/settings/organizations/members", |
There was a problem hiding this comment.
Members goes away from settings, that's why we have this icon in the side bar and it's opened in a new tab. I think we should do the same for the home screen as well
| href: "/settings/organizations/billing", | ||
| }, | ||
| { | ||
| titleKey: "oAuth", |
There was a problem hiding this comment.
We have this twice, was this done on purpose? Both redirect to developer/oauth
| items: SettingsItem[]; | ||
| } | ||
|
|
||
| export const settingsSections: SettingsSection[] = [ |
There was a problem hiding this comment.
Some are missing, for example:
- settings/my-account/features
- /settings/organizations/sso
- /settings/organizations/roles
| href: "/settings/organizations/attributes", | ||
| }, | ||
| { | ||
| titleKey: "privacy", |
There was a problem hiding this comment.
should probably be called "Privacy & security" like in the side menu
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 8 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/web/modules/settings/home/settings-home-data.ts">
<violation number="1" location="apps/web/modules/settings/home/settings-home-data.ts:131">
P2: `/settings/organizations/members` is an internal route, but marking it as `isExternalLink` forces a new-tab `<a>` and external-link icon. This breaks expected internal navigation and prefetch behavior.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| descriptionKey: "settings_home_org_members_description", | ||
| icon: "users", | ||
| href: "/settings/organizations/members", | ||
| isExternalLink: true, |
There was a problem hiding this comment.
P2: /settings/organizations/members is an internal route, but marking it as isExternalLink forces a new-tab <a> and external-link icon. This breaks expected internal navigation and prefetch behavior.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/modules/settings/home/settings-home-data.ts, line 131:
<comment>`/settings/organizations/members` is an internal route, but marking it as `isExternalLink` forces a new-tab `<a>` and external-link icon. This breaks expected internal navigation and prefetch behavior.</comment>
<file context>
@@ -121,6 +128,7 @@ export const settingsSections: SettingsSection[] = [
descriptionKey: "settings_home_org_members_description",
icon: "users",
href: "/settings/organizations/members",
+ isExternalLink: true,
},
{
</file context>
There was a problem hiding this comment.
Reviewed the Cubic AI feedback on this PR. The only issue identified (violation #1 about isExternalLink on /settings/organizations/members) has a confidence score of 7/10, which is below the threshold for automated fixes.
Additionally, this isExternalLink: true was intentionally added in the "Fix comments" commit to address @CarinaWolli's review feedback, which noted that the members page navigates away from settings and should open in a new tab — matching the existing sidebar behavior. No changes needed here.
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
CarinaWolli
left a comment
CarinaWolli
left a comment
There was a problem hiding this comment.
- "Guest notifications" is still missing
- SSO vs SAML --> different name, let's name it the same to avoid confusion
Is there a way to get back to the home screen after clicking an item? I think there should be
I asked Ciaran about this: https://www.figma.com/design/4s22GCSZGIgGyGmzwfZKOi?node-id=7-89478#1637901042
I find it unintuitive that there isn’t an easy way to get back to the home screen after clicking a setting
| } | ||
|
|
||
| export const settingsSections: SettingsSection[] = [ | ||
| { |
There was a problem hiding this comment.
I was wondering, instead of listing all settings again, could we reuse what we already have in the settings sidebar? That way we also avoid missing settings on the home screen when new ones are added to the sidebar
3 participants
Implements this Figma design: https://www.figma.com/design/4s22GCSZGIgGyGmzwfZKOi/Cal.com-3.0-Redesign?node-id=7-9&t=kQgqpKERu0PAtYxL-1
Summary by cubic
Introduced a new Settings home at /settings with a clean, card-based grid that adapts to org membership and admin role. Updated navigation so both the bottom nav and user dropdown open this home, and added a quick home shortcut in the sidebar.
New Features
Navigation
Written for commit bbf2897. Summary will update on new commits.