test: add missing negation operator tests for TEXT, NUMBER, and compound rules#27690
Merged
Udit-takkar merged 8 commits intomainfrom Feb 17, 2026
Merged
Conversation
…und rules Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
Udit-takkar
approved these changes
Feb 17, 2026
Contributor
E2E results are ready! |
emrysal
pushed a commit
that referenced
this pull request
Feb 18, 2026
…und rules (#27690) * Fix exclusion filter - include all team members * Fix display when members aren't saved in the DB * Update tests * test: add missing negation operator tests for TEXT, NUMBER, and compound rules Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> * fix: revert non-intentional changes to AddMembersWithSwitch.tsx Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> --------- Co-authored-by: Joe Au-Yeung <j.auyeung419@gmail.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds additional integration test coverage for the exclusion/negation attribute filter regression fixed in #27669. During review of that PR, the following test gaps were identified:
not_equalandnot_likewith users who have no TEXT attribute assignednot_equalwith users who have no NUMBER attribute assignedselect_not_equalsrules where users are missing different attributesThese 5 new tests complement the 8 tests added in #27669 (which covered SINGLE_SELECT and MULTI_SELECT negation operators).
No production code changes — test-only.
Updates since last revision
main(the test file was renamed from.test.tsto.integration-test.tson main)createAttributesScenario, dynamiccreatedUsers[n].userId,testFixtures.team.id/testFixtures.org.id)AddMembersWithSwitch.tsx— the diff now contains only test additionsMandatory Tasks (DO NOT REMOVE)
How should this be tested?
Run the integration test file:
TZ=UTC VITEST_MODE=integration yarn test packages/features/routing-forms/lib/findTeamMembersMatchingAttributeLogic.integration-test.tsAll tests should pass, including the 5 new ones for TEXT/NUMBER negation and compound rules.
Things for reviewer to verify
createAttributesScenario's option-to-user mapping. Verify this accurately represents how these attribute types store values in production.buildQueryValuedirectly (instead ofbuildSelectTypeFieldQueryValue) because TEXT/NUMBER fields needvalueType: ["text"]/["number"]rather than the default["select"]."5","10") in the scenario, which matches how the system processes them throughcaseInsensitive(getValueOfAttributeOption(...)). Confirm this is accurate.properties.conjunctionis not explicitly set in the query value. Confirm this matches production behavior.Link to Devin run: https://app.devin.ai/sessions/cf62bcf87df84468b26928d8681738ee
Requested by: @hariombalhara