fix(routing-forms): use direct eventTypeId lookup instead of brittle slug extraction#27722
Closed
deepshekhardas wants to merge 1 commit intocalcom:mainfrom
Closed
Conversation
|
Paragon Review Unavailable Hi @deepshekhardas! To enable Paragon reviews on this repository, please register at https://home.polarity.cc Once registered, connect your GitHub account and Paragon will automatically review your pull requests. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
Member
sahitya-chandra
left a comment
sahitya-chandra
left a comment
There was a problem hiding this comment.
@deepshekhardas pr is directly related to routing-form, no before and after video of the changes have been provided.
Also description does not follow the pr template. Closing this now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses the TODO in SharedRoutingFormResponseService to use direct eventTypeId lookup instead of extracting event type from the URL slug.
Changes
Why?
The slug-based lookup was fragile and could break if slugs change. Using direct eventTypeId is more reliable.
Type of change