forked from vectordotdev/vector
-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/blockbox exporter labels #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er tests The blackbox_exporter tests require more time due to HTTP probing. To accommodate this, specific timeout settings have been added for these tests. This includes a slow-timeout period of 5 minutes and a hard timeout period of 10 minutes.
…ontext 1. Updated 'blackbox_exporter_http.yaml' to include optional labels for geographic and infrastructure context. This provides more detailed information about the probe location and infrastructure provider. 2. Created a new file 'blackbox_exporter_labels.yaml' that demonstrates the use of both predefined optional labels and custom ad-hoc labels. This allows for more flexibility in providing context to the metrics. 3. Updated 'blackbox_exporter_multiple.yaml' to include ad-hoc custom labels for additional context. This allows for arbitrary contextual information to be added to the metrics.
… metrics This commit introduces optional labels to the blackbox_exporter source. These labels provide additional context about the probe location and infrastructure. Users can now configure predefined labels (geohash, region, location, country, name, provider) and/or custom ad-hoc labels using the `labels` map. This feature enhances the usability of the blackbox_exporter source by providing more detailed and customizable metrics.
Adds comprehensive unit, integration, and property-based tests for the Blackbox exporter source. These tests cover: - Probe URL construction and encoding - Prometheus text format parsing - Configuration validation - Metric enrichment and tag injection, including conflict resolution - Optional label injection - Error isolation across targets
…etter identification This commit introduces optional labels to the BlackboxExporterConfig struct. These labels include geohash, region, location, country, name, provider, and custom labels. These labels will be added to all scraped metrics, providing more detailed information about the probe and the infrastructure it's running on. This will help in better identification and categorization of the metrics.
…Hub Actions workflow This change is made to ensure that tests are run before the build process. This way, if any test fails, the build process will not proceed, saving resources and time.
…its checksum file The changes were made to simplify the naming of the release archive and its checksum file by removing the specific architecture details from the file names. This change will make it easier for users to download and install the release, as they no longer need to know the specific architecture details.
…ub Actions workflow This change was made to optimize the workflow by building the vector package once before running the tests, instead of building it separately in the 'Build Vector' step. This reduces redundancy and improves the efficiency of the workflow.
…rkflow - Split the "Build Vector and Run Tests" step into two separate steps: "Run Tests" and "Build Vector". This change improves the readability and maintainability of the workflow. - Add support for 'feat/*' branches to trigger the workflow. This allows testing new features before they are merged into the main or master branches. - Change the runner for the 'release' job from 'ubuntu-latest' to 'vector-builder'. This ensures that the release is built in a consistent environment. - Add a condition to the 'release' job to only run if the current branch is 'main' or 'master'. This prevents accidental releases from feature branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.