Skip to content

fix(android): properly set android background color #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
okwasniewski merged 2 commits into from
Jan 26, 2025
Merged

fix(android): properly set android background color #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e47397
fix(android): properly set android background color
okwasniewski Jan 26, 2025
7c5bde9
docs: add missing changesets
okwasniewski Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-bobcats-juggle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'react-native-bottom-tabs': patch
---

fix: properly set background color on Android
5 changes: 5 additions & 0 deletions .changeset/two-socks-tie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'react-native-bottom-tabs': patch
---

fix: iOS crash on old architecture when setting font style
18 changes: 3 additions & 15 deletions packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package com.rcttabview

import android.annotation.SuppressLint
import android.content.Context
import android.content.res.ColorStateList
import android.graphics.Color
import android.graphics.drawable.ColorDrawable
import android.graphics.drawable.Drawable
import android.os.Build
Expand All @@ -20,14 +20,10 @@ import android.widget.LinearLayout
import android.widget.TextView
import androidx.core.view.children
import androidx.core.view.forEachIndexed
import androidx.core.view.isGone
import androidx.core.view.isVisible
import androidx.viewpager2.widget.ViewPager2
import coil3.ImageLoader
import coil3.asDrawable
import coil3.request.ImageRequest
import coil3.svg.SvgDecoder
import com.facebook.react.bridge.ReactContext
import com.facebook.react.bridge.ReadableArray
import com.facebook.react.common.assets.ReactFontManager
import com.facebook.react.modules.core.ReactChoreographer
Expand All @@ -38,8 +34,7 @@ import com.google.android.material.navigation.NavigationBarView.LABEL_VISIBILITY
import com.google.android.material.navigation.NavigationBarView.LABEL_VISIBILITY_UNLABELED
import com.google.android.material.transition.platform.MaterialFadeThrough

class ReactBottomNavigationView(context: ReactContext) : LinearLayout(context) {
private val reactContext: ReactContext = context
class ReactBottomNavigationView(context: Context) : LinearLayout(context) {
private val bottomNavigation = BottomNavigationView(context)
val layoutHolder = FrameLayout(context)

Expand Down Expand Up @@ -335,11 +330,7 @@ class ReactBottomNavigationView(context: ReactContext) : LinearLayout(context) {
val colorDrawable = ColorDrawable(backgroundColor)

bottomNavigation.itemBackground = colorDrawable
backgroundTintList = ColorStateList.valueOf(backgroundColor)
// Set navigationBarColor for edge-to-edge.
if (Utils.isEdgeToEdge()) {
reactContext.currentActivity?.window?.navigationBarColor = backgroundColor
}
bottomNavigation.backgroundTintList = ColorStateList.valueOf(backgroundColor)
}

fun setActiveTintColor(color: Int?) {
Expand Down Expand Up @@ -430,9 +421,6 @@ class ReactBottomNavigationView(context: ReactContext) : LinearLayout(context) {

override fun onDetachedFromWindow() {
super.onDetachedFromWindow()
if (Utils.isEdgeToEdge()) {
reactContext.currentActivity?.window?.navigationBarColor = Color.TRANSPARENT
}
imageLoader.shutdown()
}
}
8 changes: 0 additions & 8 deletions packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/Utils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,5 @@ class Utils {
)
return baseColor.defaultColor
}

// Detect `react-native-edge-to-edge` (https://github.com/zoontek/react-native-edge-to-edge)
fun isEdgeToEdge() = try {
Class.forName("com.zoontek.rnedgetoedge.EdgeToEdgePackage")
true
} catch (exception: ClassNotFoundException) {
false
}
}
}
Loading