fix: upgrade material to alpha10 so dynamic tabBarIcon works on Material 3 #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
After some more testing it seems like the bug reappears after opening and closing a modal on top of the bottom tabs navigator. But this change at least makes it a bit better. Earlier it was completely impossible to change |
Member
|
Thanks for this PR! If you are still running into issues can you describe it in an Issue? |
okwasniewski
approved these changes
Feb 7, 2025
Contributor
Author
Thank you! Created an issue describing the bug here: #298 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a app theme with a Material 3 parent theme a dynamic
tabBarIconbased onfocusedstopped working in version 0.8.0. This change fixes this