Skip to content

fix(ios): prevent header showing on iPad when using a custom one #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
okwasniewski merged 1 commit into from
Feb 10, 2025
Merged

fix(ios): prevent header showing on iPad when using a custom one #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/purple-beers-laugh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'react-native-bottom-tabs': patch
---

fix: prevent header showing on iPad when using a custom one
15 changes: 15 additions & 0 deletions packages/react-native-bottom-tabs/ios/TabViewImpl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ struct TabViewImpl: View {
}
.tag(tabData?.key)
.tabBadge(tabData?.badge)
.hideTabBar(props.tabBarHidden)
.onAppear {
#if !os(macOS)
updateTabBarAppearance(props: props, tabBar: tabBar)
Expand Down Expand Up @@ -351,6 +352,20 @@ extension View {
self
}
}

@ViewBuilder
func hideTabBar(_ flag: Bool) -> some View {
if flag {
if #available(iOS 16.0, *) {
self.toolbar(.hidden, for: .tabBar)
} else {
// We fallback to isHidden on UITabBar
self
}
} else {
self
}
}

// Allows TabView to use unfilled SFSymbols.
// By default they are always filled.
Expand Down
Loading