Skip to content

feat: implement drawable cache #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
okwasniewski merged 1 commit into from
Feb 14, 2025
Merged

feat: implement drawable cache #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,11 @@ class ReactBottomNavigationView(context: Context) : LinearLayout(context) {
var onNativeLayoutListener: ((width: Double, height: Double) -> Unit)? = null
var disablePageAnimations = false
var items: MutableList<TabInfo> = mutableListOf()
private val iconSources: MutableMap<Int, ImageSource> = mutableMapOf()
private val drawableCache: MutableMap<ImageSource, Drawable> = mutableMapOf()

private var isLayoutEnqueued = false
private var selectedItem: String? = null
private val iconSources: MutableMap<Int, ImageSource> = mutableMapOf()
private var activeTintColor: Int? = null
private var inactiveTintColor: Int? = null
private val checkedStateSet = intArrayOf(android.R.attr.state_checked)
Expand Down Expand Up @@ -309,10 +310,18 @@ class ReactBottomNavigationView(context: Context) : LinearLayout(context) {

@SuppressLint("CheckResult")
private fun getDrawable(imageSource: ImageSource, onDrawableReady: (Drawable?) -> Unit) {
drawableCache[imageSource]?.let {
onDrawableReady(it)
return
}
val request = ImageRequest.Builder(context)
.data(imageSource.getUri(context))
.target { drawable ->
post { onDrawableReady(drawable.asDrawable(context.resources)) }
post {
val stateDrawable = drawable.asDrawable(context.resources)
drawableCache[imageSource] = stateDrawable
onDrawableReady(stateDrawable)
}
}
.listener(
onError = { _, result ->
Expand Down
Loading