Skip to content

feat: skip screen measurements when using custom tab bar #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
okwasniewski merged 1 commit into from
Feb 17, 2025
Merged

feat: skip screen measurements when using custom tab bar #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-carpets-cheat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'react-native-bottom-tabs': patch
---

feat: skip measurements when using custom tab bar
5 changes: 4 additions & 1 deletion packages/react-native-bottom-tabs/src/TabView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@

if (!loaded.includes(focusedKey)) {
// Set the current tab to be loaded if it was not loaded before
setLoaded((loaded) => [...loaded, focusedKey]);

Check warning on line 222 in packages/react-native-bottom-tabs/src/TabView.tsx

View workflow job for this annotation

GitHub Actions / lint 

'loaded' is already declared in the upper scope on line 218 column 10
}

const icons = React.useMemo(
Expand Down Expand Up @@ -334,7 +334,10 @@
key={route.key}
freeze={!!freeze}
focused={focused}
style={[styles.screen, measuredDimensions]}
style={[
styles.screen,
renderCustomTabBar ? styles.fullWidth : measuredDimensions,
]}
>
{renderScene({
route,
Expand Down
Loading