Skip to content

fix: don't crash when no elements are found #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
okwasniewski merged 2 commits into from
Feb 26, 2025
Merged

fix: don't crash when no elements are found #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3817bd0
fix: don't crash when no elements are found
okwasniewski Feb 26, 2025
7fc7d1a
Create metal-rocks-shop.md
okwasniewski Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-rocks-shop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-native-bottom-tabs": patch
---

fix(android): don't crash when no elements are found
2 changes: 1 addition & 1 deletion packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ class ReactBottomNavigationView(context: Context) : LinearLayout(context) {

private fun updateTintColors() {
// First let's check current item color.
val currentItemTintColor = items.first { it.key == selectedItem }.activeTintColor
val currentItemTintColor = items.firstOrNull { it.key == selectedItem }?.activeTintColor

// getDefaultColor will always return a valid color but to satisfy the compiler we need to check for null
val colorPrimary = currentItemTintColor ?: activeTintColor ?: Utils.getDefaultColorFor(
Expand Down
Loading