Skip to content

fix(android): remove unnecessary override causing issues #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
okwasniewski merged 2 commits into from
Mar 25, 2025
Merged

fix(android): remove unnecessary override causing issues #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e381bd
fix: remove unnecessary override causing issues
okwasniewski Mar 25, 2025
78c5a8d
Create tricky-waves-tap.md
okwasniewski Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tricky-waves-tap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-native-bottom-tabs": patch
---

fix(android): remove unnecessary override causing issues
3 changes: 0 additions & 3 deletions packages/react-native-bottom-tabs/android/src/newarch/RCTTabViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,6 @@ class RCTTabViewManager(context: ReactApplicationContext) :
override fun setTranslucent(view: ReactBottomNavigationView?, value: Boolean) {
}

override fun setIgnoresTopSafeArea(view: ReactBottomNavigationView?, value: Boolean) {
}

override fun setSidebarAdaptable(view: ReactBottomNavigationView?, value: Boolean) {
}

Expand Down
Loading