Skip to content

fix: typo in cmakeListsPath for turbo native modules #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 13, 2024
Merged

fix: typo in cmakeListsPath for turbo native modules #629

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99a84dc
fix(android): fix typo in cmakeListsPath for turbo native modules
withSang Sep 11, 2024
faeafd0
fix(android): fix typo in cmakeListsPath for turbo native local modules
withSang Sep 13, 2024
e576f3a
fix(format): fix indentation in react-native.config ejs file
withSang Sep 13, 2024
80264d9
test if example app is vanilla instead of checking if its local
atlj Sep 13, 2024
6e6a6ae
remove unused local property
atlj Sep 13, 2024
fb225ad
add _ again
atlj Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/create-react-native-library/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,7 @@ async function create(_argv: yargs.Arguments<any>) {
repo: repoUrl,
example,
year: new Date().getFullYear(),
local,
};

const copyDir = async (source: string, dest: string) => {
Expand Down
4 changes: 4 additions & 0 deletions packages/create-react-native-library/templates/native-library-mixed/react-native.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ module.exports = {
dependency: {
platforms: {
android: {
<%_ if (local) { -%>
cmakeListsPath: 'build/generated/source/codegen/jni/CMakeLists.txt',
<%_ } else { -%>
cmakeListsPath: 'generated/jni/CMakeLists.txt',
<%_ } -%>
},
},
},
Expand Down
4 changes: 4 additions & 0 deletions packages/create-react-native-library/templates/native-library-new/react-native.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ module.exports = {
dependency: {
platforms: {
android: {
<%_ if (local) { -%>
cmakeListsPath: 'build/generated/source/codegen/jni/CMakeLists.txt',
<%_ } else { -%>
cmakeListsPath: 'generated/jni/CMakeLists.txt',
<%_ } -%>
},
},
},
Expand Down
4 changes: 4 additions & 0 deletions packages/create-react-native-library/templates/native-view-mixed/react-native.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ module.exports = {
dependency: {
platforms: {
android: {
<%_ if (local) { -%>
cmakeListsPath: 'build/generated/source/codegen/jni/CMakeLists.txt',
<%_ } else { -%>
cmakeListsPath: 'generated/jni/CMakeLists.txt',
<%_ } -%>
},
},
},
Expand Down
4 changes: 4 additions & 0 deletions packages/create-react-native-library/templates/native-view-new/react-native.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ module.exports = {
dependency: {
platforms: {
android: {
<%_ if (local) { -%>
cmakeListsPath: 'build/generated/source/codegen/jni/CMakeLists.txt',
<%_ } else { -%>
cmakeListsPath: 'generated/jni/CMakeLists.txt',
<%_ } -%>
},
},
},
Expand Down
Loading