fix: single answer questions dont get stored with metadata #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atlj
force-pushed
the
@atlj/default-options-in-metadata
branch
from
3c80800 to
beb7826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a question has a single answer on
create-react-native-library, we skip that question. However, due to a bug, single answer questions weren't making it to the metadata stored with new project. This PR fixes thatTest plan
A good example is the
Fabric view with backward compat. This option had a single language settingkotlin and objective c. To test this PR, you can create a new project with these options and make sure the language is getting stored properly.