Skip to content

fix: spawn CLI directly without using Node #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 17, 2024
Merged

fix: spawn CLI directly without using Node #689

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8f16a3
fix: spawn CLI directly without using Node
gronxb Nov 16, 2024
12eb971
fix: lint
gronxb Nov 16, 2024
3fe5042
refactor: not using spread
gronxb Nov 16, 2024
05070a8
feat: remove xcode compatibility
atlj Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/react-native-builder-bob/src/utils/runRNCCli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ import path from 'node:path';
import fs from 'fs-extra';
import assert from 'node:assert';

// This is a special case for calling bob from the XCode scripts
// XCode scripts don't have the node binary properly set
// We expose an env value for node instead.
const NODE_BINARY = process.env['NODE_BINARY'] || 'node';
const NODE_BINARY = 'node';

/**
* Runs the React Native Community CLI with the specified arguments
Expand All @@ -27,7 +24,7 @@ export async function runRNCCli(
rncCliBinaryName
);

return await spawn(NODE_BINARY, [RNC_CLI_BINARY_PATH, ...args], options);
return await spawn(RNC_CLI_BINARY_PATH, args, options);
}

async function getCliBinaryName(): Promise<string> {
Expand Down
Loading