Fix: Ensure 'invokeLibraryCodegen' task executes 'npx' correctly on all OS #707
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…ll OS - Resolved an issue where 'invokeLibraryCodegen' failed with 'file not found' when running 'yarn android'.\n- Added OS-specific handling:\n - On Windows: Use 'cmd /c' to execute the command.\n - On other systems: Use 'sh -c' to execute the command.\n- This change ensures 'npx bob build --target codegen' runs successfully regardless of the operating system.
ddiazFG
force-pushed
the
fix-invoke-android-codegen
branch
from
1ed2242 to
faa6c8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Important
feel free to close it if it only fails because a local configuration is incorrect.
Summary
Fixed the error "Execution failed for task ':app:invokeLibraryCodegen'" when running yarn android in the Fabric View Library. The invokeLibraryCodegen task now correctly executes npx on all platforms by checking the OS and using cmd or sh accordingly.
Test plan
Before the fix: Run
yarn androidon example forlder and observe the build failing with the mentioned error.Apply the fix: Update the build script with the provided solution.
After the fix: Run yarn android again and confirm that the build succeeds without errors.